[feature/monitoring] Implement /metrics for the operator. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k-operator into feature/monitoring
…k-operator into feature/monitoring
… into feature/monitoring
… into feature/monitoring
… into feature/monitoring
Cellebyte
force-pushed
the
feature/monitoring
branch
from
42e622d
to
d7f9d91
Compare
There was a problem hiding this comment.
Great work overall!
Most of the issues are cosmetic changes.
I did not list some issues found with linter, as those can be always checked by running the scan.
Other things that should be fixed would be to add proper error wrapping (not sure if I found all the places where that should be done), add comments to the exported structs/functions etc. and remove redundant code that is commented out.
Co-authored-by: p-strusiewiczsurmacki-mobica <137421299+p-strusiewiczsurmacki-mobica@users.noreply.github.com>
… into feature/monitoring
Co-authored-by: p-strusiewiczsurmacki-mobica <137421299+p-strusiewiczsurmacki-mobica@users.noreply.github.com>
Co-authored-by: p-strusiewiczsurmacki-mobica <137421299+p-strusiewiczsurmacki-mobica@users.noreply.github.com>
|
The only thing which currently does not work is the end2end route export stuff in the lab which is provided with this Pull Request. For that I would need @chdxD1 to check and fix. But this could also be done later. |
Cellebyte
changed the title
watzkuh
reviewed
Sep 5, 2023
Co-authored-by: Kai <kai@naschinski.de>
Co-authored-by: Kai <kai@naschinski.de>
Co-authored-by: Kai <kai@naschinski.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some information on exported metrics and how they are exported.
metrics.txt