Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch and Table not providing Styles Attribute #328

Closed
Lalaluka opened this issue May 10, 2021 · 5 comments
Closed

Switch and Table not providing Styles Attribute #328

Lalaluka opened this issue May 10, 2021 · 5 comments

Comments

@Lalaluka
Copy link
Contributor

Lalaluka commented May 10, 2021

Hey,
i noticed that Scale Switch and Table do not provide styles Attributes like every other element.
Is there a specific reason for that? Will that change in the future?

It's a bit weird to have it a different way for just two components.

@oddcelot
Copy link
Collaborator

Hi there,
thanks for the input 🙂
I will check if there's a deeper thought behind it, but i guess this got lost somewhere down the road.
And yes, inconsistencies should be avoided. So if you find anything else that's a bit fishy, let us know 🎣

I will go through the other components aswell for this 😉

@nowseemee
Copy link
Collaborator

The styles prop is to be removed since we have css variables and the shadow parts.

@Lalaluka
Copy link
Contributor Author

So instead of adding styles to table and switch it would help more to remove Shadow DOM from other components?

@nowseemee
Copy link
Collaborator

We should remove the styles prop from all components - shadow DOM should stay as it is ✌️

@nowseemee
Copy link
Collaborator

Fixed in #378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants