Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular-base): ignore imports for frameworks like angular which are imported directly in modules #496

Merged
merged 3 commits into from
Oct 23, 2020

Conversation

JayaKrishnaNamburu
Copy link
Member

I was doing a round of local testing and noticed that angular-projects are breaking. There is a small bug which is causing a problem with imports and breaking them.

@JayaKrishnaNamburu JayaKrishnaNamburu added bug Something isn't working angular generators labels Oct 22, 2020
@JayaKrishnaNamburu JayaKrishnaNamburu self-assigned this Oct 22, 2020
@JayaKrishnaNamburu JayaKrishnaNamburu changed the title fix(angular-base): ignore imports for frameworks like angular which are imported directly in modules WIP | fix(angular-base): ignore imports for frameworks like angular which are imported directly in modules Oct 22, 2020
@JayaKrishnaNamburu JayaKrishnaNamburu changed the title WIP | fix(angular-base): ignore imports for frameworks like angular which are imported directly in modules fix(angular-base): ignore imports for frameworks like angular which are imported directly in modules Oct 22, 2020
@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #496 into development will increase coverage by 0.18%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #496      +/-   ##
===============================================
+ Coverage        76.65%   76.83%   +0.18%     
===============================================
  Files              156      156              
  Lines             5525     5525              
  Branches          1228     1228              
===============================================
+ Hits              4235     4245      +10     
+ Misses            1223     1213      -10     
  Partials            67       67              
Impacted Files Coverage Δ
...gin-common/src/node-handlers/node-to-html/index.ts 60.86% <0.00%> (ø)
...kages/teleport-project-generator-next/src/utils.ts 86.79% <0.00%> (+1.88%) ⬆️
...s/teleport-project-generator-gridsome/src/utils.ts 100.00% <0.00%> (+11.11%) ⬆️
...es/teleport-project-generator-stencil/src/utils.ts 90.90% <0.00%> (+72.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4a7c6b...4baa4a0. Read the comment docs.

@JayaKrishnaNamburu JayaKrishnaNamburu changed the title fix(angular-base): ignore imports for frameworks like angular which are imported directly in modules WIP | fix(angular-base): ignore imports for frameworks like angular which are imported directly in modules Oct 22, 2020
@JayaKrishnaNamburu JayaKrishnaNamburu changed the title WIP | fix(angular-base): ignore imports for frameworks like angular which are imported directly in modules fix(angular-base): ignore imports for frameworks like angular which are imported directly in modules Oct 23, 2020
@JayaKrishnaNamburu JayaKrishnaNamburu requested review from Utwo and removed request for Utwo October 23, 2020 07:03
@JayaKrishnaNamburu JayaKrishnaNamburu merged commit 62bd2b6 into development Oct 23, 2020
@JayaKrishnaNamburu JayaKrishnaNamburu deleted the fix/angular-imports branch March 10, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular generators bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants