Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(validator): improved validation checks for used tokens and project style references #505

Merged
merged 1 commit into from
Nov 11, 2020
Merged

refactor(validator): improved validation checks for used tokens and project style references #505

merged 1 commit into from
Nov 11, 2020

Conversation

JayaKrishnaNamburu
Copy link
Member

@JayaKrishnaNamburu JayaKrishnaNamburu added the core This issue involves changes inside the core module of the generators label Nov 11, 2020
@JayaKrishnaNamburu JayaKrishnaNamburu added this to the 0.15 milestone Nov 11, 2020
@JayaKrishnaNamburu JayaKrishnaNamburu self-assigned this Nov 11, 2020
@JayaKrishnaNamburu JayaKrishnaNamburu linked an issue Nov 11, 2020 that may be closed by this pull request
Improvements for Component's content validation #501
Closed
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #505 (45bb320) into development (cf102e5) will decrease coverage by 0.26%.
The diff coverage is 47.05%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #505      +/-   ##
===============================================
- Coverage        76.63%   76.37%   -0.27%     
===============================================
  Files              156      156              
  Lines             5650     5692      +42     
  Branches          1267     1284      +17     
===============================================
+ Hits              4330     4347      +17     
- Misses            1251     1275      +24     
- Partials            69       70       +1
Impacted Files Coverage Δ
...ges/teleport-uidl-validator/src/validator/utils.ts 70.27% <46.00%> (-8.76%) ⬇️
...ges/teleport-uidl-validator/src/validator/index.ts 88.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf102e5...45bb320. Read the comment docs.

@JayaKrishnaNamburu JayaKrishnaNamburu merged commit cf742d5 into development Nov 11, 2020
@Utwo Utwo deleted the refactor/validation-checks branch November 11, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Utwo Utwo Utwo approved these changes

Assignees

@JayaKrishnaNamburu JayaKrishnaNamburu

Labels
core This issue involves changes inside the core module of the generators
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.

Improvements for Component's content validation
2 participants
@JayaKrishnaNamburu @Utwo