Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(react-jss): React JSS will use hooks add styles to nodes. #526

Merged
merged 2 commits into from
Jan 5, 2021

Conversation

JayaKrishnaNamburu
Copy link
Member

Fixes #521

@JayaKrishnaNamburu JayaKrishnaNamburu added the style flavours All issues and pull requests that are relates to styles. (Adding a style plugins, making a change) label Jan 1, 2021
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #526 (e1cd6b5) into development (87fdeb2) will decrease coverage by 0.08%.
The diff coverage is 76.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #526      +/-   ##
===============================================
- Coverage        76.31%   76.22%   -0.09%     
===============================================
  Files              156      156              
  Lines             5687     5692       +5     
  Branches          1205     1209       +4     
===============================================
- Hits              4340     4339       -1     
- Misses            1288     1292       +4     
- Partials            59       61       +2     
Impacted Files Coverage Δ
packages/teleport-plugin-react-jss/src/utils.ts 55.55% <66.66%> (-1.59%) ⬇️
packages/teleport-plugin-react-jss/src/index.ts 84.76% <78.94%> (-3.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87fdeb2...e1cd6b5. Read the comment docs.

@JayaKrishnaNamburu JayaKrishnaNamburu changed the title refactor(react-jss): refactoring react-jss to use hooks refactor(react-jss): React JSS will use hooks add styles to nodes. Jan 5, 2021
@Utwo Utwo merged commit ac2208d into development Jan 5, 2021
@Utwo Utwo deleted the refactor/plugin-react-jss branch January 5, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style flavours All issues and pull requests that are relates to styles. (Adding a style plugins, making a change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade react-jss to use hooks based style creation and usage.
2 participants