Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoping component styles with comp name for styled-jsx #607

Merged
merged 2 commits into from
Sep 21, 2021

Conversation

JayaKrishnaNamburu
Copy link
Member

fixes #606

@JayaKrishnaNamburu JayaKrishnaNamburu changed the title Scoping component styles with comp name Scoping component styles with comp name for styled-jsx Sep 16, 2021
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #607 (56ad1a9) into development (754b3b2) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #607   +/-   ##
============================================
  Coverage        73.85%   73.85%           
============================================
  Files              185      185           
  Lines             6479     6483    +4     
  Branches          1661     1663    +2     
============================================
+ Hits              4785     4788    +3     
  Misses            1672     1672           
- Partials            22       23    +1     
Impacted Files Coverage Δ
...ages/teleport-plugin-react-styled-jsx/src/index.ts 75.75% <80.00%> (-0.29%) ⬇️
...es/teleport-component-generator-react/src/index.ts 97.36% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 754b3b2...56ad1a9. Read the comment docs.

@JayaKrishnaNamburu JayaKrishnaNamburu merged commit f7db6dc into development Sep 21, 2021
@JayaKrishnaNamburu JayaKrishnaNamburu deleted the fix/scope-styled-jsx branch September 21, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styles from projectStyleSheet can collide with styles generated from component.
1 participant