Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Donny Yung <donaldyung@datawire.io>
  • Loading branch information
Donny Yung committed Jul 22, 2021
1 parent 20797b7 commit 963ba1b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
8 changes: 4 additions & 4 deletions reference/intercepts.md
Expand Up @@ -42,10 +42,10 @@ Telepresence can import the environment variables from the pod that is being int

## Creating an intercept without a local process running

If you are *are* logged into Ambassador Cloud, when you create an intercept the Traffic
Agent does a GET request to your service and the process running on your local machine
at the port specified in your intercept to determine if they support HTTP/2. This is
required for the selective intercepts to behave correctly.
The Traffic Agent sends a GET request to your service and the process running on your
local machine at the port specified in your intercept to determine if they support HTTP/2,
if you *are* logged into Ambassador Cloud. This is required for selective intercepts to
behave correctly.

If you do not have a service running locally, the Traffic Agent will use the result
it gets from the HTTP check against your app in the cluster to configure requests
Expand Down
7 changes: 3 additions & 4 deletions releaseNotes.yml
Expand Up @@ -38,10 +38,9 @@ items:
- type: bugfix
title: Better UX around intercepts with no local process running
body: >-
When initiating an intercept before you have a local process running,
it would result in requests hanging indefinitely. This has been fixed
and will result in an <code>Empty reply from server</code> until you
start a local process.
Requests would hang indefinitely when initiating an intercept before you
had a local process running. This has been fixed and will result in an
<code>Empty reply from server</code> until you start a local process.
docs: reference/intercepts

- version: 2.3.6
Expand Down

0 comments on commit 963ba1b

Please sign in to comment.