New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap deployment preserves original command for container #226

Closed
jwickens opened this Issue Jul 17, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@jwickens

jwickens commented Jul 17, 2017

when using --swap-deployment the original command (and I assume args) spec for the container is preserved. This causes the telepresence container to never start when the original spec specifies a command that does not exist in the telepresence container.

@itamarst

This comment has been minimized.

Contributor

itamarst commented Jul 17, 2017

Sorry you encountered a bug, and many thanks for reporting it. I'll go fix it (and I guess audit the Pod spec to see if there's anything else I should be modifying when swapping.)

@itamarst itamarst added the bug label Jul 17, 2017

@itamarst itamarst added this to In progress in Telepresence Jul 17, 2017

@itamarst

This comment has been minimized.

Contributor

itamarst commented Jul 17, 2017

Looks like the following container options should be reset in swapped-out version:

  • workingDir
  • command
  • terminationMessagePolicy (set this to stderr probably?)
  • livenessProbe
  • readinessProbe
  • args

itamarst added a commit that referenced this issue Jul 18, 2017

Merge pull request #227 from datawire/swap-more-parameters
Swap more parameters out in --swap-deployment.

Fixes #226.
@itamarst

This comment has been minimized.

Contributor

itamarst commented Jul 18, 2017

OK, v0.59 should be available in about 30 minutes with a fix - let me know if it solves your problem!

By the way, what is your use case for Telepresence?

@itamarst

This comment has been minimized.

Contributor

itamarst commented Jul 18, 2017

OK, v0.59 is finally out (had to re-run build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment