Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Argo Rollout workloads #2406

Closed
maxlegault opened this issue Feb 17, 2022 · 0 comments · Fixed by #3651
Closed

Add support for Argo Rollout workloads #2406

maxlegault opened this issue Feb 17, 2022 · 0 comments · Fixed by #3651
Labels
feature New feature or enhancement request

Comments

@maxlegault
Copy link
Contributor

Please describe your use case / problem.
Currently, workloads that can be intercepted are Deployments, ReplicaSets and StatefulSets. It would be great to also support Argo Rollouts for users that use these workload types to leverage rollout strategies like blue/green and canary.

As of now, for a service foo that points to Rollout controlled pods, the following error is printed:

> telepresence intercept foo
telepresence: error: No interceptable deployment, replicaset, or statefulset matching foo found

Describe the solution you'd like
Support adding the traffic-agent configuration to a Rollout object. Its specs are mainly the same as a Deployment with some additional properties.

Describe alternatives you've considered
It is currently possible to intercept the ReplicaSet associated to a Rollout object like this (foo-57bc7c4959 being a ReplicaSet created by the Rollout controller):

> telepresence intercept foo --workload foo-57bc7c4959

This will work for a first time intercept, but as soon as the Rollout object gets updated, the updated ReplicaSet will be scaled down to 0 and a new one will be scaled up, replacing the traffic-agent-enabled pods.

Versions (please complete the following information)
Telepresence 2.5.0
Kubernetes 1.20

@cindymullins-dw cindymullins-dw added the feature New feature or enhancement request label Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or enhancement request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants