Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assumption about service CIDR being /16 is wrong #243

Closed
itamarst opened this issue Jul 24, 2017 · 0 comments
Closed

Assumption about service CIDR being /16 is wrong #243

itamarst opened this issue Jul 24, 2017 · 0 comments
Labels
t:bug Something isn't working

Comments

@itamarst
Copy link

itamarst commented Jul 24, 2017

E.g. @farcaller had /13 on this custom Kubernetes setup.

Some options:

  1. @farcaller proposed allowing user to customize this with env variable (Allow to override service net when heuristics fail. #238).
  2. Could add command-line option.
  3. Improve detection by making it more conservative. This could be done by being much more conservative, and assuming services don't get added much over time so doing minimal range that would cover existing services.
  4. Improve detection by making it more accurate. Unfortunately at the moment getting this information out of Kubernetes is hard, but that might change in the future. (Expose the service-cluster-ip-range CIDR through the API Server kubernetes/kubernetes#25533).

Next steps: investigate 4. If that doesn't work, combination of 2 and 3 should do the trick. I prefer not using env variables just for consistency's sake, and would prefer DTRT, or at least mostly DTRT, over requiring user to figure out obscure information.

@itamarst itamarst added the t:bug Something isn't working label Jul 24, 2017
@itamarst itamarst added this to Next in Telepresence Jul 24, 2017
@itamarst itamarst moved this from Next to In progress in Telepresence Jul 25, 2017
itamarst added a commit that referenced this issue Jul 25, 2017
Better service CIDR calculation.

Fixes #243.
@itamarst itamarst removed this from In progress in Telepresence Jul 25, 2017
donnyyung pushed a commit that referenced this issue Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant