Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(teler): add CaddyHandler{,FuncWithNext} #199

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

dwisiswant0
Copy link
Collaborator

@dwisiswant0 dwisiswant0 commented Jun 18, 2024

IMPORTANT: Please do not create a PR without creating an issue first!

(Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request).

Summary

Adds

  • CaddyHandler method,
  • CaddyHandlerFuncWithNext method.

Proposed of changes

This PR fixes/implements the following bugs/features:

  • Bug 1
  • Bug 2
  • Feature 1
  • Feature 2
  • Breaking changes

How has this been tested?

Proof:

Closing issues

Fixes #

Checklist:

  • My code follows the code style of this project.
  • My changes successfully ran and pass linters locally (run make lint).
  • I have written new tests for my changes.
    • My changes successfully ran and pass tests locally.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.27%. Comparing base (5974890) to head (192180e).
Report is 3 commits behind head on master.

Files Patch % Lines
handler.go 53.33% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
- Coverage   78.67%   78.27%   -0.41%     
==========================================
  Files          12       12              
  Lines         933      948      +15     
==========================================
+ Hits          734      742       +8     
- Misses        132      137       +5     
- Partials       67       69       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Dwi Siswanto <git@dw1.io>
@dwisiswant0 dwisiswant0 force-pushed the feat/teler/add-caddyhandler-and-funcwithnext branch from d56a949 to 192180e Compare June 19, 2024 02:09
@dwisiswant0 dwisiswant0 merged commit 784d70a into master Jun 19, 2024
8 of 10 checks passed
@dwisiswant0 dwisiswant0 deleted the feat/teler/add-caddyhandler-and-funcwithnext branch June 19, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant