Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(repl):documentation about user snippets #1379

Merged
merged 21 commits into from
Apr 20, 2023
Merged

Conversation

ntacheva
Copy link
Contributor

No description provided.

@ntacheva ntacheva added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Mar 31, 2023
@ntacheva ntacheva requested review from KristianMariyanov and a team March 31, 2023 09:26
@ntacheva ntacheva self-assigned this Mar 31, 2023
@ntacheva ntacheva requested a review from a team as a code owner March 31, 2023 09:26
@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2023

Hello @ntacheva,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create pr to production

getting-started/repl/user-snippets.md Outdated Show resolved Hide resolved
@@ -0,0 +1,39 @@
---
title: User Snippets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To better differentiate the User Snippets and the predefined snippets, I suggest changing the following attributes of the Telerik REPL for Blazor Snippets and Scaffolders article:

  • title: Predefined Snippets and Scaffolders
  • page_title: Predefined Snippets and Scaffolders in Telerik REPL for Blazor
  • H1 title: Predefined Snippets and Scaffolders in Telerik REPL for Blazor

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the "Predefined" prefix differentiates the snippets, but it doesn't provide much additional explanation of what is the kind of snippets.
Since we are using the snippets that generate code only in the editor, maybe a better name could be Editor snippets or Code Editor snippets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both for the feedback! I initially used the name "User Snippets" as the menu in the REPL tool itself is called so. However, "Code Editor Snippets" name sounds more relevant in this scenario. I renamed the article and we may also consider renaming the menu in REPL.

getting-started/repl/intergration.md Outdated Show resolved Hide resolved
getting-started/repl/intergration.md Outdated Show resolved Hide resolved
getting-started/repl/overview.md Outdated Show resolved Hide resolved
getting-started/repl/user-snippets.md Outdated Show resolved Hide resolved
getting-started/repl/user-snippets.md Outdated Show resolved Hide resolved
getting-started/repl/user-snippets.md Outdated Show resolved Hide resolved
getting-started/repl/user-snippets.md Outdated Show resolved Hide resolved
getting-started/repl/user-snippets.md Outdated Show resolved Hide resolved
ntacheva and others added 20 commits April 20, 2023 16:15
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
Co-authored-by: Yordan <60105689+yordan-mitev@users.noreply.github.com>
@ntacheva ntacheva merged commit 3a5bbc2 into master Apr 20, 2023
@github-actions
Copy link
Contributor

Here you are the link to your PR to production: 1399

@github-actions github-actions bot deleted the repls-docs-users branch April 20, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-to-production Use this label to get a comment to choose whether to merge the PR to production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants