Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KB] Add Grid Inline Form KB #2110

Merged
merged 21 commits into from
May 22, 2024
Merged

[KB] Add Grid Inline Form KB #2110

merged 21 commits into from
May 22, 2024

Conversation

svdimitr
Copy link
Contributor

No description provided.

@svdimitr svdimitr requested a review from a team May 16, 2024 10:34
@svdimitr svdimitr self-assigned this May 16, 2024
@svdimitr svdimitr requested a review from a team as a code owner May 16, 2024 10:34
Copy link
Contributor

@ikoevska ikoevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the notes within:

  • Consider adding a link on components/grid/editing/inline.md to this newly created KB. That would help with SEO.
  • Is this KB valid only for inline editing? Would it work for incell editing, for example? If it works for other editing modes, you might want to note that inside.

knowledge-base/grid-inline-edit-form.md Outdated Show resolved Hide resolved
knowledge-base/grid-inline-edit-form.md Outdated Show resolved Hide resolved
knowledge-base/grid-inline-edit-form.md Show resolved Hide resolved
knowledge-base/grid-inline-edit-form.md Outdated Show resolved Hide resolved
knowledge-base/grid-inline-edit-form.md Outdated Show resolved Hide resolved
knowledge-base/grid-inline-edit-form.md Outdated Show resolved Hide resolved
knowledge-base/grid-inline-edit-form.md Outdated Show resolved Hide resolved
knowledge-base/grid-inline-edit-form.md Outdated Show resolved Hide resolved
knowledge-base/grid-inline-edit-form.md Outdated Show resolved Hide resolved
knowledge-base/grid-inline-edit-form.md Outdated Show resolved Hide resolved
svdimitr and others added 10 commits May 16, 2024 14:37
Co-authored-by: Iva Stefanova Koevska-Atanasova <koevska@progress.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <koevska@progress.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <koevska@progress.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <koevska@progress.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <koevska@progress.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <koevska@progress.com>
@svdimitr svdimitr requested a review from ikoevska May 16, 2024 12:33
@svdimitr svdimitr added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label May 16, 2024
Copy link
Contributor

Hello @svdimitr,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

Comment on lines +187 to +193
{
Id = ++LastId,
Name = $"Name {LastId}",
Price = rnd.Next(1, 100) * 1.23m,
Quantity = rnd.Next(0, 1000),
StartDate = DateTime.Today.AddDays(-rnd.Next(1, 30)).AddMonths(-rnd.Next(1, 100))
});
Copy link
Contributor

@dimodi dimodi May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does VS for Windows really add one more tab here? VS Mac doesn't do that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was formatted by VS for Windows. I am not sure why.

svdimitr and others added 7 commits May 17, 2024 15:43
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@svdimitr svdimitr merged commit 6d6b029 into master May 22, 2024
1 check passed
Copy link
Contributor

Here you are the link to your PR to production: 2127

@github-actions github-actions bot deleted the kb-grid-inline-form branch May 22, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-to-production Use this label to get a comment to choose whether to merge the PR to production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants