Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawer causes scrollbar with the header height #104

Closed
marin-bratanov opened this issue Jul 3, 2021 · 1 comment
Closed

Drawer causes scrollbar with the header height #104

marin-bratanov opened this issue Jul 3, 2021 · 1 comment
Assignees
@EdCharbeneau

Comments

@marin-bratanov
Copy link
Contributor

marin-bratanov commented Jul 3, 2021 •
edited

You can see this on small viewport heights on the main page, or on other pages that have small content - there is an unnecessary scrollbar due to the 100vh height set to the drawer, and the additional 80px header which totals more than the viewport height.

2021-07-03 12_39_22-Blazing Coffee

Reported in 1526414

My proposed solution is in the PR and is based on this https://github.com/telerik/blazor-ui/tree/master/drawer/sidenav
marin-bratanov added a commit that referenced this issue Jul 3, 2021
@marin-bratanov
chore(blazingCoffee): fix drawer layout height and scrollbar #104
6452f0c
This was referenced Jul 3, 2021
Merged
Closed
EdCharbeneau added a commit that referenced this issue Jul 12, 2021
@EdCharbeneau
Merge pull request #105 from telerik/blazing-coffee-drawer-height-layout
ffb971a 
chore(blazingCoffee): fix drawer layout height and scrollbar #104
@marin-bratanov
Copy link
Contributor Author

Closing this to be live when we next upload the sample app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EdCharbeneau EdCharbeneau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EdCharbeneau @marin-bratanov