Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox/Multiselect: valueNormalizer breaks on second error observable #1872

Closed
dummdidumm opened this issue Oct 25, 2018 · 1 comment
Closed
Assignees

Comments

@dummdidumm
Copy link

I'm submitting a...

  • Bug report

Current behavior

When the observable handed to valueNormalizer throws, the input is ignored. This works as expected and is documented accordingly. However, if the observable throws a second time, the dropdowns break.

Expected behavior

valueNormalizer should handle all error observables.

Minimal reproduction of the problem with instructions

Multiselect

  1. Go to https://www.telerik.com/kendo-angular-ui/components/dropdowns/multiselect/custom-values/
  2. Open Stackblitz of last section "handling errors"
  3. Enter a custom value into the multiselect -> input is ignored as expected
  4. Enter a custom value one more time -> input gets through

Combobox

  1. Go to https://www.telerik.com/kendo-angular-ui/components/dropdowns/combobox/custom-values/
  2. Open Stackblitz of last section "handling errors"
  3. Enter a custom value into the combobox -> input is ignored as expected
  4. Enter a custom value one more time -> endless spinner, there is an error in the console

For both dropdowns, there also sometimes pops up the Angular "ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked"-error.

Browser:

Affects all Browsers

@dimitar-pechev
Copy link
Contributor

The fix is shipped in v3.3.0 of the @progress/kendo-angular-dropdowns package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants