This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves two problems:
After merging, the height and IDs can be modified via snippet metadata. The default height of snippets is now 280px, and the iframe id is inferred by the previous heading in the document, prefixed with
example-
. For example, "Basic Usage" implies that the next snippet will haveid="example-basic-usage"
If a document heading changes, and there is a snippet after it, it would be nice to keep the old id after the change:
Before:
After:
/cc @ipeshev @yordanov @dmihaylo