This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
feat(buttons): Add new design styles and improvements #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joneff
suggested changes
Jan 11, 2017
| kendo-dropdownbutton.k-state-focused, | ||
| kendo-dropdownbutton:focus { | ||
| outline: 0; | ||
| .k-dropdownbutton { |
There was a problem hiding this comment.
If we have k-split-button, then this should be k-dropdown-button, or vice versa -- k-splitbutton and k-dropdownbutton.
The rest is fine.
There was a problem hiding this comment.
Seems to be the same question that we had for the button-group and buttongroup, no? telerik/kendo-angular-buttons#45
There was a problem hiding this comment.
Changed the class name to k-dropdown-button.
gyoshev
reviewed
Jan 11, 2017
|
|
||
| $primary-focused-box-shadow: 0 0 0 2px lighten($primary-button-bg, 23%) !default; | ||
| $primary-active-box-shadow: inset 0 3px 5px desaturate($primary-button-bg, 3%) !default; | ||
| $primary-focused-box-shadow: 0 3px 4px 0 rgba(255, 99, 88, .06) !default; |
There was a problem hiding this comment.
How is this color calculated? seems related to $accent.
There was a problem hiding this comment.
It is exactly the $accent color. I was unaware that I could use a hex variable inside an RGBA function in SASS. Corrected now.
joneff
approved these changes
Jan 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.