Skip to content

Commit

Permalink
fix(popup): make padding of popups 0
Browse files Browse the repository at this point in the history
  • Loading branch information
joneff committed Dec 9, 2021
1 parent cf4c2cb commit d567a72
Show file tree
Hide file tree
Showing 11 changed files with 22 additions and 26 deletions.
4 changes: 2 additions & 2 deletions packages/bootstrap/scss/menu/_variables.scss
Expand Up @@ -45,8 +45,8 @@ $menu-scroll-button-hover-gradient: null !default;


// Menu popup
$menu-popup-padding-x: $popup-padding-x !default;
$menu-popup-padding-y: $popup-padding-y !default;
$menu-popup-padding-x: null !default;
$menu-popup-padding-y: null !default;
$menu-popup-border-width: $popup-border-width !default;
$menu-popup-font-size: $font-size !default;
$menu-popup-line-height: $line-height !default;
Expand Down
4 changes: 2 additions & 2 deletions packages/bootstrap/scss/popup/_variables.scss
@@ -1,6 +1,6 @@
// Popup
$popup-padding-x: 0px !default;
$popup-padding-y: 8px !default;
$popup-padding-x: null !default;
$popup-padding-y: null !default;
$popup-border-width: 1px !default;
$popup-border-radius: $border-radius !default;

Expand Down
4 changes: 2 additions & 2 deletions packages/classic/scss/menu/_variables.scss
Expand Up @@ -47,8 +47,8 @@ $menu-scroll-button-hover-gradient: null !default;


// Menu popup
$menu-popup-padding-x: $popup-padding-x !default;
$menu-popup-padding-y: $popup-padding-y !default;
$menu-popup-padding-x: null !default;
$menu-popup-padding-y: null !default;
$menu-popup-border-width: $popup-border-width !default;
$menu-popup-font-size: $font-size !default;
$menu-popup-line-height: $line-height !default;
Expand Down
4 changes: 2 additions & 2 deletions packages/classic/scss/popup/_variables.scss
@@ -1,6 +1,6 @@
// Popup
$popup-padding-x: 0px !default;
$popup-padding-y: 0px !default;
$popup-padding-x: null !default;
$popup-padding-y: null !default;
$popup-border-width: 1px !default;
$popup-border-radius: null !default;

Expand Down
10 changes: 4 additions & 6 deletions packages/default/scss/menu/_layout.scss
Expand Up @@ -126,7 +126,8 @@
// Sub menu
.k-menu-group {
margin: 0;
padding: $menu-popup-padding-y $menu-popup-padding-x;
padding: 0;
// padding: $menu-popup-padding-y $menu-popup-padding-x;
font-size: $menu-popup-font-size;
line-height: $menu-popup-line-height;
list-style: none;
Expand Down Expand Up @@ -174,13 +175,10 @@
}
.k-context-menu {
margin: 0;
padding: $menu-popup-padding-y $menu-popup-padding-x;
padding: 0;
// padding: $menu-popup-padding-y $menu-popup-padding-x;
border-width: $menu-popup-border-width;
border-style: solid;

&.k-menu-horizontal {
padding: $menu-popup-padding-x $menu-popup-padding-y;
}
}
.k-animation-container .k-context-menu.k-menu-horizontal {
// kendo-jquery adds `display: block` via js and we need to override it.
Expand Down
4 changes: 2 additions & 2 deletions packages/default/scss/menu/_variables.scss
Expand Up @@ -47,8 +47,8 @@ $menu-scroll-button-hover-gradient: null !default;


// Menu popup
$menu-popup-padding-x: $popup-padding-x !default;
$menu-popup-padding-y: $popup-padding-y !default;
$menu-popup-padding-x: null !default;
$menu-popup-padding-y: null !default;
$menu-popup-border-width: $popup-border-width !default;
$menu-popup-font-size: $font-size !default;
$menu-popup-line-height: $line-height !default;
Expand Down
3 changes: 2 additions & 1 deletion packages/default/scss/popup/_layout.scss
Expand Up @@ -3,7 +3,8 @@
.k-popup {
@include border-radius( $popup-border-radius );
margin: 0;
padding: $popup-padding-y $popup-padding-x;
padding: 0;
// padding: $popup-padding-y $popup-padding-x;
border-width: $popup-border-width;
border-style: solid;
box-sizing: border-box;
Expand Down
4 changes: 2 additions & 2 deletions packages/default/scss/popup/_variables.scss
@@ -1,6 +1,6 @@
// Popup
$popup-padding-x: 0px !default;
$popup-padding-y: 0px !default;
$popup-padding-x: null !default;
$popup-padding-y: null !default;
$popup-border-width: 1px !default;
$popup-border-radius: null !default;

Expand Down
3 changes: 0 additions & 3 deletions packages/default/scss/spreadsheet/_layout.scss
Expand Up @@ -701,9 +701,6 @@
}
.k-reset-color { border-bottom-width: 1px; }
.k-custom-color { border-top-width: 1px; }
.k-spreadsheet-color-palette {
padding: $popup-padding-y;
}
.k-spreadsheet-border-type-palette {
width: 12.5rem;
height: 5rem;
Expand Down
4 changes: 2 additions & 2 deletions packages/material/scss/menu/_variables.scss
Expand Up @@ -47,8 +47,8 @@ $menu-scroll-button-hover-gradient: null !default;


// Menu popup
$menu-popup-padding-x: $popup-padding-x !default;
$menu-popup-padding-y: $popup-padding-y !default;
$menu-popup-padding-x: null !default;
$menu-popup-padding-y: null !default;
$menu-popup-border-width: $popup-border-width !default;
$menu-popup-font-size: $font-size !default;
$menu-popup-line-height: $line-height !default;
Expand Down
4 changes: 2 additions & 2 deletions packages/material/scss/popup/_variables.scss
@@ -1,6 +1,6 @@
// Popup
$popup-padding-x: 0px !default;
$popup-padding-y: 0px !default;
$popup-padding-x: null !default;
$popup-padding-y: null !default;
$popup-border-width: 0px !default;
$popup-border-radius: null !default;

Expand Down

0 comments on commit d567a72

Please sign in to comment.