Skip to content

Commit

Permalink
feat: detach font icons from the themes
Browse files Browse the repository at this point in the history
BREAKING CHANGE: detach font icons from the themes

Starting with the R3 2023 release, the font icons font is no longer
bundled in the themes distribution. This is done as part of a series of
improvements related to content security policy(CSP). Continue using
font icons in your project can still be achieved by loading the font and
 related styles separately through CDN or directly from the kendo-font-icons package.

* Add a k-font-icon class for all font icons
* Add a k-icon class for all svg icons
  • Loading branch information
inikolova authored and Juveniel committed Sep 26, 2023
1 parent b54adcd commit de49a95
Show file tree
Hide file tree
Showing 75 changed files with 293 additions and 519 deletions.
76 changes: 37 additions & 39 deletions packages/bootstrap/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/bootstrap/package.json
Expand Up @@ -50,7 +50,7 @@
"postpublish": "echo 'no postpublish for bootstrap theme'"
},
"dependencies": {
"@progress/kendo-font-icons": "1.9.0",
"@progress/kendo-svg-icons": "2.0.0",
"@progress/kendo-theme-core": "7.0.0-dev.0",
"@progress/kendo-theme-default": "7.0.0-dev.0",
"@progress/kendo-theme-utils": "7.0.0-dev.0",
Expand Down
3 changes: 1 addition & 2 deletions packages/bootstrap/scss/grid/_theme.scss
Expand Up @@ -142,8 +142,7 @@
.k-grid-filter,
.k-header-column-menu,
.k-grid-header-menu,
.k-hierarchy-cell .k-icon,
.k-hierarchy-cell .k-svg-icon {
.k-hierarchy-cell .k-icon {
&:focus,
&.k-focus {
box-shadow: inset 0 0 0 2px rgba( black, .1 );
Expand Down
76 changes: 37 additions & 39 deletions packages/classic/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/classic/package.json
Expand Up @@ -50,7 +50,7 @@
"postpublish": "echo 'no postpublish for classic theme'"
},
"dependencies": {
"@progress/kendo-font-icons": "1.9.0",
"@progress/kendo-svg-icons": "2.0.0",
"@progress/kendo-theme-core": "7.0.0-dev.0",
"@progress/kendo-theme-default": "7.0.0-dev.0",
"@progress/kendo-theme-utils": "7.0.0-dev.0"
Expand Down
46 changes: 23 additions & 23 deletions packages/default/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/default/package.json
Expand Up @@ -49,7 +49,7 @@
"postpublish": "echo 'no postpublish for default theme'"
},
"dependencies": {
"@progress/kendo-font-icons": "1.9.0",
"@progress/kendo-svg-icons": "2.0.0",
"@progress/kendo-theme-core": "7.0.0-dev.0",
"@progress/kendo-theme-utils": "7.0.0-dev.0"
}
Expand Down
3 changes: 1 addition & 2 deletions packages/default/scss/breadcrumb/_layout.scss
Expand Up @@ -76,8 +76,7 @@
}

.k-breadcrumb-link > .k-image,
.k-breadcrumb-icontext-link .k-icon,
.k-breadcrumb-icontext-link .k-svg-icon {
.k-breadcrumb-icontext-link .k-icon {
margin-inline-end: $kendo-breadcrumb-link-icon-spacing;
}

Expand Down
4 changes: 1 addition & 3 deletions packages/default/scss/colorgradient/_layout.scss
Expand Up @@ -167,14 +167,12 @@
align-items: center;
gap: k-math-div( $kendo-color-gradient-contrast-spacer, 2 );

.k-icon,
.k-svg-icon {
.k-icon {
vertical-align: middle;
}

// Needed for the double check icons
.k-icon + .k-icon,
.k-svg-icon + .k-svg-icon,
.k-icon-wrapper-host + .k-icon-wrapper-host .k-icon {
margin-inline-start: -13px;
}
Expand Down
1 change: 0 additions & 1 deletion packages/default/scss/drawer/_layout.scss
Expand Up @@ -153,7 +153,6 @@
gap: $kendo-drawer-item-padding-x;
}

.k-svg-icon,
.k-icon {
flex-shrink: 0;
padding-inline: $kendo-drawer-icon-padding-x;
Expand Down

0 comments on commit de49a95

Please sign in to comment.