Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons not rendered in SASS themes #1687

Closed
Dimitar-Goshev opened this issue Jul 7, 2020 · 4 comments · Fixed by #1868
Closed

Icons not rendered in SASS themes #1687

Dimitar-Goshev opened this issue Jul 7, 2020 · 4 comments · Fixed by #1868
Assignees
Labels
Bug Something isn't working FW:Blazor Issue related blazor-ui FW:jQuery Issue related to kendo-jquery SEV:Normal
Projects
Milestone

Comments

@Dimitar-Goshev
Copy link
Contributor

Describe the bug
There are icons not rendered in SASS themes.
The icons exist - https://docs.telerik.com/kendo-ui/styles-and-layout/icons-web#list-of-font-icons
And they are visible if the respective code is applied to the before element or if LESS themes are used.

To reproduce
Steps to reproduce the behavior:

  1. Run the following Dojo snippet

Expected behavior
Untitled _ Kendo UI Dojo - Google Chrome 2020-07-07 14 17 19
Achieved with LESS themes - https://dojo.telerik.com/@Dimitar-Goshev/ipOsoFAl

Current behavior
Untitled _ Kendo UI Dojo - Mozilla Firefox 2020-07-07 14 18 24

Affected package

  • theme-default
  • theme-bootstrap
  • theme-material

Affected suites (please remove the unneeded items)

  • Kendo UI for jQuery - 2020.2.617

Affected browsers (please remove the unneeded items)

  • All
@Dimitar-Goshev Dimitar-Goshev added Bug Something isn't working SEV:Medium FW:jQuery Issue related to kendo-jquery labels Jul 7, 2020
@marin-bratanov
Copy link
Contributor

There are a few more, see here: https://dojo.telerik.com/iNePUxam

@marin-bratanov marin-bratanov added the FW:Blazor Issue related blazor-ui label Aug 3, 2020
@joneff joneff added this to Needs triage in Bug hunt via automation Sep 14, 2020
@joneff joneff added this to the 2021.1 milestone Sep 14, 2020
@joneff
Copy link
Member

joneff commented Sep 14, 2020

Looking at the code, it appears the icons are there, but the entries are not added. I can't say why exactly.

With the new process of kendo-font-icons, that will not be an issue. I will provide a one time ad-hoc fix and then we'll work on integrating kendo-font-icons package in the pipeline.

@joneff
Copy link
Member

joneff commented Sep 15, 2020

I've prepared a sample dojo, using the latest kendo-font-icons -- https://dojo.telerik.com/@joneff/APuSowiB.

Note: i will be using only the icon list from that file, not the content of the font, because it still has some issues.

@joneff joneff self-assigned this Sep 15, 2020
joneff added a commit that referenced this issue Sep 15, 2020
@joneff joneff mentioned this issue Sep 15, 2020
@joneff
Copy link
Member

joneff commented Sep 15, 2020

Note: chart-line and shape-line both used the line name. That led to some conflict. As a result, I prefixed all chart icons with that prefix.

The icons are not removed, just renamed! Even so, I doubt it will be a good idea to have this in kendo-jquery. We could wait for 2020 R3 SP1 and then introduce the changes there.

Bug hunt automation moved this from Needs triage to Closed Sep 15, 2020
joneff added a commit that referenced this issue Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working FW:Blazor Issue related blazor-ui FW:jQuery Issue related to kendo-jquery SEV:Normal
Projects
No open projects
Bug hunt
Closed
Development

Successfully merging a pull request may close this issue.

3 participants