Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus styles are applied to elements in Chrome #1796

Closed
Stamo-Gochev opened this issue Aug 28, 2020 · 3 comments · Fixed by #1864
Closed

Focus styles are applied to elements in Chrome #1796

Stamo-Gochev opened this issue Aug 28, 2020 · 3 comments · Fixed by #1864
Assignees
@joneff
Labels
Bug Something isn't working C:Grid Enhancement New feature of an existing functionality or an improvement of an existing functionality.
Projects
Bug hunt
Milestone
2021.1

Comments

@Stamo-Gochev
Copy link
Contributor

Describe the bug
As of recently, Chromium-based browsers add additional focus styles (a border) around focused elements, e.g.:
image

To reproduce
Steps to reproduce the behavior:

  1. Go to https://winslaveblazor.dev.progress.com/blazor-ui/grid/column-menu
  2. Click on the column menu icon inside a grid header cell to open it

Expected behavior
No additional styles are added to the first focused element (except our own like from k-state-focused)

Screenshots
image

Affected package (please remove the unneeded items)

  • theme-default
  • theme-bootstrap
  • theme-material

Affected suites (please remove the unneeded items)

  • Telerik UI for Blazor

Affected browsers (please remove the unneeded items)

  • All
  • Chrome version: 84
@Stamo-Gochev Stamo-Gochev added the Bug Something isn't working label Aug 28, 2020
@joneff joneff added this to the 2020.3 milestone Sep 9, 2020
@joneff joneff added this to Needs triage in Bug hunt via automation Sep 14, 2020
@joneff joneff added C:Grid Enhancement New feature of an existing functionality or an improvement of an existing functionality. labels Sep 14, 2020
@joneff joneff self-assigned this Sep 14, 2020
joneff added a commit that referenced this issue Sep 14, 2020
@joneff
fix(grid): remove focus outline from column menu items (#1796)
4657d21
joneff added a commit that referenced this issue Sep 14, 2020
@joneff
fix(grid): add styles for column menu focus items (#1796)
c11dfb0
@joneff joneff mentioned this issue Sep 14, 2020
Merged
Bug hunt automation moved this from Needs triage to Closed Sep 14, 2020
joneff added a commit that referenced this issue Sep 14, 2020
@joneff
fix(grid): remove focus outline from column menu items (#1796)
b4af05e
joneff added a commit that referenced this issue Sep 14, 2020
@joneff
fix(grid): add styles for column menu focus items (#1796)
8faa5d4
@matanasov
Copy link

@joneff
I now see similar behavior in the Scheduler component:
https://winslaveblazor.dev.progress.com/blazor-ui-production/scheduler/overview

image

@matanasov matanasov reopened this Sep 15, 2020
@joneff
Copy link
Contributor

joneff commented Sep 16, 2020

I suppose there will be many cases where something is focusable and we haven't removed the focus from it.

We'll target this.

@joneff joneff modified the milestones: 2020.3, 2021.1 Dec 15, 2020
@joneff joneff mentioned this issue Dec 18, 2020
Open
@joneff
Copy link
Contributor

joneff commented Dec 18, 2020

@matanasov I opened a new issues, because this one is done.

@joneff joneff closed this as completed Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joneff joneff

Labels
Bug Something isn't working C:Grid Enhancement New feature of an existing functionality or an improvement of an existing functionality.
Projects
No open projects
Bug hunt
Closed
Milestone
2021.1
Development

Successfully merging a pull request may close this issue.

Blazor fixes telerik/kendo-themes
3 participants
@joneff @Stamo-Gochev @matanasov