Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorGradient - SVG Contrast Tool Lines #2959

Closed
preslavapetrova1 opened this issue Nov 12, 2021 · 2 comments · Fixed by #2993
Closed

ColorGradient - SVG Contrast Tool Lines #2959

preslavapetrova1 opened this issue Nov 12, 2021 · 2 comments · Fixed by #2993
Assignees
Labels
C:Colorpicker Enhancement New feature of an existing functionality or an improvement of an existing functionality.
Milestone

Comments

@preslavapetrova1
Copy link

The following properties should be added to the .k-color-contrast-svg selector for the SVG contrast tool lines.

position: absolute; overflow: visible; pointer-events: none; left: 0px; top: 0px;

Screenshot 2021-11-12 at 11 44 09

Without them, it does not work and looks like this:

Screenshot 2021-11-12 at 11 44 57

@preslavapetrova1 preslavapetrova1 added the Bug Something isn't working label Nov 12, 2021
@JoomFX JoomFX self-assigned this Nov 26, 2021
@silviyaboteva
Copy link
Contributor

I think this is not a bug, but an enhancement as currently, the KendoReact implementation have these styles inline and the color contrast looks ok: https://www.telerik.com/kendo-react-ui/components/inputs/colorgradient/color-contrast/

We can just move the inline styles to the themes via class name.

@JoomFX
Copy link
Contributor

JoomFX commented Nov 26, 2021

@silviyaboteva Yes, this is the exact purpose of this issue - to move the styles in the themes so the components do not have them inline :)

Yep, the "bug" tag is not the best one in this case.

@joneff joneff added C:Colorpicker Enhancement New feature of an existing functionality or an improvement of an existing functionality. and removed Bug Something isn't working labels Nov 26, 2021
@joneff joneff added this to the 2022.1 milestone Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Colorpicker Enhancement New feature of an existing functionality or an improvement of an existing functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants