Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Material for ComboBox - Kendo UI #44

Closed
magdalenaan opened this issue Feb 28, 2018 · 4 comments · Fixed by #73 or #124
Closed

Implement Material for ComboBox - Kendo UI #44

magdalenaan opened this issue Feb 28, 2018 · 4 comments · Fixed by #73 or #124
Assignees
@magdalenaan
Labels
C:Combobox Enhancement New feature of an existing functionality or an improvement of an existing functionality. T:Material Kendo Theme Material
Milestone
2018.2

Comments

@magdalenaan
Copy link
Contributor

magdalenaan commented Feb 28, 2018 •
edited

related telerik/kendo#8250
@magdalenaan magdalenaan self-assigned this Feb 28, 2018
magdalenaan pushed a commit that referenced this issue Feb 28, 2018
feat(dropdowns): add Material theme for dropdowns and inputs
f97ffec 
#40 #43 #44 #45
@magdalenaan magdalenaan mentioned this issue Feb 28, 2018
Merged
magdalenaan pushed a commit that referenced this issue Feb 28, 2018
@magdalenaan
feat(dropdowns): add Material theme for dropdowns and inputs
618c73d 
#40 #43 #44 #45
@Dimitar-Goshev
Copy link
Contributor

Dimitar-Goshev commented Mar 8, 2018 •
edited

  • Bottom border width should become 2px on hover - part of Ripple, to be implemented with Ripple
  • Bottom border of disabled ComboBox is not dotted
  • The expand arrow of ComboBox does not change its direction upwards in expanded state.
  • The expand arrow of invalid ComboBox (class k-state-invalid added) is red, but by design its color should not change:
    image
  • Invalid state should have 2px border - part of Ripple, to be implemented with Ripple
  • If an invalid ComboBox (class k-state-invalid added) is hovered, the normal hover state is applied
  • Displaced loading icon, similar to AutoComplete:
    image
  • Grouping - missing design - logged for implementation

theOrlin pushed a commit that referenced this issue Mar 13, 2018
@theOrlin
feat(dropdowns): add Material theme for dropdowns and inputs
3a8c589 
#40 #43 #44 #45
magdalenaan pushed a commit that referenced this issue Mar 14, 2018
feat(dropdowns): improve expand arrow color for the invalid state
63cab70 
#44 #40
@magdalenaan
Copy link
Contributor Author

magdalenaan commented Mar 14, 2018 •
edited

Waiting for design for grouping implementation to finish the issue.

magdalenaan pushed a commit that referenced this issue Mar 20, 2018
feat(dropdowns): improve expand arrow color for the invalid state
e256763 
#44 #40
@magdalenaan magdalenaan mentioned this issue Mar 28, 2018
Merged
4 tasks
magdalenaan pushed a commit that referenced this issue Apr 4, 2018
chore(dropdowns): add styles for grouping headers
c09da36 
#40 #43 #44 #45
@magdalenaan magdalenaan mentioned this issue Apr 4, 2018
Merged
gyoshev pushed a commit that referenced this issue Apr 5, 2018
@magdalenaan @gyoshev
chore(dropdowns): add styles for grouping headers (#109)
e368ddb 
* chore(dropdowns): add styles for grouping headers

#40 #43 #44 #45

* chore(dropdowns): improve grouping variables

#109
@Dimitar-Goshev
Copy link
Contributor

Dimitar-Goshev commented Apr 10, 2018 •
edited

  • Grouping header is not all caps and it should be higher than other items - design:
    image
  • RTL - Loading icon is not on the left:
    image

magdalenaan pushed a commit that referenced this issue Apr 11, 2018
chore(dropdowns): improve invalid dropdowns appearance
82538d7 
#44 #43 #40 #45
@magdalenaan magdalenaan mentioned this issue Apr 11, 2018
Merged
magdalenaan pushed a commit that referenced this issue Apr 11, 2018
@magdalenaan
chore(dropdowns): improve invalid dropdowns appearance
fe2581e 
#44 #43 #40 #45
gyoshev pushed a commit that referenced this issue Apr 11, 2018
@magdalenaan @gyoshev
chore(dropdowns): add styles for grouping headers (#109)
52376ee 
* chore(dropdowns): add styles for grouping headers

#40 #43 #44 #45

* chore(dropdowns): improve grouping variables

#109
gyoshev pushed a commit that referenced this issue Apr 11, 2018
@gyoshev
chore(dropdowns): improve invalid dropdowns appearance
ff42f95 
#44 #43 #40 #45
magdalenaan pushed a commit that referenced this issue Apr 11, 2018
chore(dropdowns): fix issues logged after testing
72bc36e 
#40 #43 #44 #45
magdalenaan pushed a commit that referenced this issue Apr 11, 2018
chore(dropdowns): fix issues logged after testing
79db63d 
#40 #43 #44 #45
@magdalenaan magdalenaan mentioned this issue Apr 11, 2018
Merged
4 tasks
magdalenaan pushed a commit that referenced this issue Apr 11, 2018
chore(dropdowns): fix issues logged after testing
749cb36 
#40 #43 #44 #45
magdalenaan pushed a commit that referenced this issue Apr 16, 2018
@magdalenaan
chore(dropdowns): fix issues logged after testing
53c0617 
#40 #43 #44 #45
@Dimitar-Goshev
Copy link
Contributor

Dimitar-Goshev commented Apr 16, 2018 •
edited by magdalenaan

  • Group tags are not swapped in RTL (All SASS themes): - Still reproducible
    image

magdalenaan pushed a commit that referenced this issue Apr 18, 2018
chore(dropdowns): improve dropdowns appearance
bea0d56 
- position correctly multiselect placeholder
- center loading icon vertically
- fix wrong groups tags position in RTL
- place loading icon for inputs (mult-row multiselect) on the bottom line
#40 #43 #44 #45
@magdalenaan magdalenaan mentioned this issue Apr 18, 2018
Merged
magdalenaan pushed a commit that referenced this issue Apr 19, 2018
chore(dropdowns): imrpove loading and clear icons positioning
cbcc4a9 
#40 #43 #44 #45
magdalenaan pushed a commit that referenced this issue Apr 19, 2018
chore(dropdowns): improve combobox select button width
1cae4a8 
#44
magdalenaan pushed a commit that referenced this issue Apr 19, 2018
chore(combobox): fix horizontal position of clear button
c0415a8 
#44
magdalenaan pushed a commit that referenced this issue Apr 19, 2018
chore(dropdowns): improve combobox select button width
2a22ada 
#44
magdalenaan pushed a commit that referenced this issue Apr 19, 2018
chore(combobox): fix horizontal position of clear button
92dc42c 
#44
magdalenaan pushed a commit that referenced this issue Apr 23, 2018
chore(dropdowns): improve dropdowns appearance
9b78cfb 
- position correctly multiselect placeholder
- center loading icon vertically
- fix wrong groups tags position in RTL
- place loading icon for inputs (mult-row multiselect) on the bottom line
#40 #43 #44 #45
magdalenaan pushed a commit that referenced this issue Apr 23, 2018
chore(dropdowns): improve combobox select button width
c107d66 
#44
magdalenaan pushed a commit that referenced this issue Apr 23, 2018
chore(combobox): fix horizontal position of clear button
4487577 
#44
magdalenaan pushed a commit that referenced this issue Apr 23, 2018
@magdalenaan
chore(dropdowns): improve dropdowns appearance
2d79df2 
- position correctly multiselect placeholder
- center loading icon vertically
- fix wrong groups tags position in RTL
- place loading icon for inputs (mult-row multiselect) on the bottom line
#40 #43 #44 #45
magdalenaan pushed a commit that referenced this issue Apr 23, 2018
@magdalenaan
chore(dropdowns): improve combobox select button width
6976efc 
#44
magdalenaan pushed a commit that referenced this issue Apr 23, 2018
@magdalenaan
chore(combobox): fix horizontal position of clear button
0d5e6a6 
#44
@Dimitar-Goshev Dimitar-Goshev mentioned this issue Jul 23, 2018
Closed
56 tasks
@joneff joneff added this to the 2018.2 milestone Jan 25, 2022
@joneff joneff added Enhancement New feature of an existing functionality or an improvement of an existing functionality. T:Material Kendo Theme Material labels Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magdalenaan magdalenaan

Labels
C:Combobox Enhancement New feature of an existing functionality or an improvement of an existing functionality. T:Material Kendo Theme Material
Projects
None yet
Milestone
2018.2
3 participants
@joneff @magdalenaan @Dimitar-Goshev