Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Material for ComboBox - Kendo UI #44

Closed
mvgmvg opened this issue Feb 28, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@mvgmvg
Copy link
Contributor

commented Feb 28, 2018

@Dimitar-Goshev

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2018

  • Bottom border width should become 2px on hover - part of Ripple, to be implemented with Ripple
  • Bottom border of disabled ComboBox is not dotted
  • The expand arrow of ComboBox does not change its direction upwards in expanded state.
  • The expand arrow of invalid ComboBox (class k-state-invalid added) is red, but by design its color should not change:
    image
  • Invalid state should have 2px border - part of Ripple, to be implemented with Ripple
  • If an invalid ComboBox (class k-state-invalid added) is hovered, the normal hover state is applied
  • Displaced loading icon, similar to AutoComplete:
    image
  • Grouping - missing design - logged for implementation
@mvgmvg

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2018

Waiting for design for grouping implementation to finish the issue.

mvgmvg added a commit that referenced this issue Apr 4, 2018

gyoshev added a commit that referenced this issue Apr 5, 2018

chore(dropdowns): add styles for grouping headers (#109)
* chore(dropdowns): add styles for grouping headers

#40 #43 #44 #45

* chore(dropdowns): improve grouping variables

#109
@Dimitar-Goshev

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2018

  • Grouping header is not all caps and it should be higher than other items - design:
    image
  • RTL - Loading icon is not on the left:
    image

mvgmvg added a commit that referenced this issue Apr 11, 2018

gyoshev added a commit that referenced this issue Apr 11, 2018

chore(dropdowns): add styles for grouping headers (#109)
* chore(dropdowns): add styles for grouping headers

#40 #43 #44 #45

* chore(dropdowns): improve grouping variables

#109

gyoshev added a commit that referenced this issue Apr 11, 2018

mvgmvg added a commit that referenced this issue Apr 11, 2018

mvgmvg added a commit that referenced this issue Apr 11, 2018

mvgmvg added a commit that referenced this issue Apr 11, 2018

mvgmvg added a commit that referenced this issue Apr 16, 2018

@Dimitar-Goshev

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2018

  • Group tags are not swapped in RTL (All SASS themes): - Still reproducible
    image

mvgmvg added a commit that referenced this issue Apr 18, 2018

chore(dropdowns): improve dropdowns appearance
- position correctly multiselect placeholder
- center loading icon vertically
- fix wrong groups tags position in RTL
- place loading icon for inputs (mult-row multiselect) on the bottom line
#40 #43 #44 #45

mvgmvg added a commit that referenced this issue Apr 19, 2018

mvgmvg added a commit that referenced this issue Apr 19, 2018

mvgmvg added a commit that referenced this issue Apr 19, 2018

mvgmvg added a commit that referenced this issue Apr 19, 2018

mvgmvg added a commit that referenced this issue Apr 23, 2018

chore(dropdowns): improve dropdowns appearance
- position correctly multiselect placeholder
- center loading icon vertically
- fix wrong groups tags position in RTL
- place loading icon for inputs (mult-row multiselect) on the bottom line
#40 #43 #44 #45

mvgmvg added a commit that referenced this issue Apr 23, 2018

chore(dropdowns): improve dropdowns appearance
- position correctly multiselect placeholder
- center loading icon vertically
- fix wrong groups tags position in RTL
- place loading icon for inputs (mult-row multiselect) on the bottom line
#40 #43 #44 #45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.