chore: add RadioGroup & RadioItem Component spec #4665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhpenkov
force-pushed
the
radio-group-spec
branch
from
91c3334
to
a404f8f
Compare
zhpenkov
changed the title
kspeyanski
requested changes
Aug 22, 2023
zhpenkov
force-pushed
the
radio-group-spec
branch
from
a4f6731
to
f0e2cf6
Compare
kspeyanski
approved these changes
Aug 23, 2023
inikolova
reviewed
Aug 25, 2023
inikolova
reviewed
Aug 25, 2023
zhpenkov
force-pushed
the
radio-group-spec
branch
2 times, most recently
from
86fda7f
to
f39dc5b
Compare
inikolova
reviewed
Aug 28, 2023
zhpenkov
force-pushed
the
radio-group-spec
branch
from
5ca934e
to
68cf46e
Compare
inikolova
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RadioGroup and RadioItem specs were added to ensure consistency and unify the theme component rendering with the suite's implementation.
Note:
The tests have been updated according to the new specs.
New test for RadioGroup has been added.