chore: add colorpicker templates #4697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhpenkov
force-pushed
the
colorpicker-templates
branch
from
0b28b73
to
86591a4
Compare
|
I would suggest to rename the colorpicker-gradient/ colorpicker-palette templates and add popup in their names. As an example: colorpicker-popup-gradient / colorpicker-popup-palette (for consistency with the other components) |
|
Also, I would suggest to separate the colorpicker.tsx test - in my opinion, it would be better to have one test, which demonstrates different sizes and another - different states. |
zhpenkov
force-pushed
the
colorpicker-templates
branch
2 times, most recently
from
0ff99b3
to
3819999
Compare
epetrow
approved these changes
Sep 19, 2023
inikolova
reviewed
Sep 19, 2023
|
Please rename the colorpicker-dropdown.tsx to colorpicker-opened.tsx for consistency |
zhpenkov
force-pushed
the
colorpicker-templates
branch
from
9e882e5
to
dffcd5d
Compare
inikolova
reviewed
Sep 20, 2023
zhpenkov
force-pushed
the
colorpicker-templates
branch
from
a22baf3
to
bd044cc
Compare
inikolova
approved these changes
Sep 20, 2023
zhpenkov
force-pushed
the
colorpicker-templates
branch
2 times, most recently
from
0ab0388
to
569c49c
Compare
zhpenkov
force-pushed
the
colorpicker-templates
branch
from
b249b5f
to
018fb4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add common ColorPicker templates and simplify tests.
Notes:
I have added
popupandopenedprops in colorpicker's spec as it is a component using popup with a specific classk-color-picker-popupto display its open state content (similar to dropdown components).