chore: add editor templates #4699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inikolova
approved these changes
Sep 19, 2023
|
Suggestion for additional templates - editor with different rendering modes, however we should update the spec, which is not part of this PR. Also, we could add disabled state and demonstrate it in a test. |
zhpenkov
force-pushed
the
editor-templates
branch
from
b7cd88e
to
a4973b3
Compare
inikolova
approved these changes
Sep 21, 2023
zhpenkov
force-pushed
the
editor-templates
branch
from
00ab7e9
to
008dccc
Compare
zhpenkov
force-pushed
the
editor-templates
branch
from
21e7891
to
463e330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add common Editor templates and simplify tests.
Notes:
Should we consider adding more templates to this component?
Added
disabledstate to editor spec.