Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aria-label value for localized Dialog #2282

Closed
2 tasks done
Iankodj opened this issue Oct 11, 2016 · 0 comments
Closed
2 tasks done

Fix aria-label value for localized Dialog #2282

Iankodj opened this issue Oct 11, 2016 · 0 comments

Comments

@Iankodj
Copy link
Contributor

Iankodj commented Oct 11, 2016

Bug report

Localization resources append text to the close button, but aria-label stays with value "Close".

Reproduction of the problem

http://runner.telerik.io/fullscreen/Icuno

Expected/desired behavior

WAI-ARIA:

  • aria-label should be assigned dynamically to the messages.close property and eventually localized;

Localization:

  • messages.close should not add text to the close button of the dialog

Environment

  • Kendo UI version: 2016.3.914
  • jQuery version: 1.12.4
  • Browser: [all]
@nlazarov nlazarov changed the title Fix WAI-ARIA attributes and Localization of Kendo Dialog Fix aria-label value for localized Dialog Oct 17, 2016
Iankodj added a commit that referenced this issue Oct 25, 2016
Iankodj added a commit that referenced this issue Oct 25, 2016
Iankodj added a commit that referenced this issue Oct 25, 2016
@jivanova jivanova added this to the 2016.Q3.SP.next milestone Nov 1, 2016
@jivanova jivanova closed this as completed Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants