Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IconClass property of command columns has to be documented and added to MVC server wrappers #3347

Closed
TsvetinaIvanova opened this issue Jun 26, 2017 · 4 comments
Closed

IconClass property of command columns has to be documented and added to MVC server wrappers #3347

TsvetinaIvanova opened this issue Jun 26, 2017 · 4 comments
Assignees
@ag-petrov @PreslavKozovski
Labels
C: Grid Documentation Enhancement S: Wrappers (ASP.NET MVC) SEV: Medium

Comments

@TsvetinaIvanova
Copy link
Contributor

TsvetinaIvanova commented Jun 26, 2017 •
edited
Loading

Bug report

The iconClass property used in fix for #2715 is not documented in the API reference and there isn't a corresponding method for it in the Fluent API. This leads to breaking changes for customers, who wrote code targeting the span element dependent on this property setting.

Also, this example has to be fixed to accommodate the changes in the custom command buttons rendering (and the changes icon classes in the Grid).

Environment

  • Kendo UI version: 2017.2.621

Ticket ID: 1116130
@hadjieva hadjieva added this to the Sprint4.R3.2017 milestone Jun 26, 2017
@ag-petrov ag-petrov modified the milestones: Sprint5.R3.2017, Sprint4.R3.2017 Jul 10, 2017
@ag-petrov
Copy link
Contributor

https://github.com/telerik/kendo/commit/4365d89e27c969e3943ee569968f84db69fd9986

@PreslavKozovski PreslavKozovski self-assigned this Jul 11, 2017
@PreslavKozovski
Copy link
Contributor

Additionally, fix this example:
http://docs.telerik.com/aspnet-mvc/helpers/grid/faq#how-to-add-kendo-ui-icons-to-custom-command-buttons

@PreslavKozovski
Copy link
Contributor

https://github.com/telerik/kendo/commit/02b6ca541b12f5bb76b11c773436bed83eaec155

@PreslavKozovski
Copy link
Contributor

https://github.com/telerik/kendo/commit/e5a438eb360a6b0eec7041f369d024de74a0b627

@PreslavKozovski PreslavKozovski mentioned this issue Oct 12, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ag-petrov ag-petrov

@PreslavKozovski PreslavKozovski

Labels
C: Grid Documentation Enhancement S: Wrappers (ASP.NET MVC) SEV: Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@TsvetinaIvanova @matanasov @hadjieva @ag-petrov @PreslavKozovski