Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PanelBar fires onSelect twice if you click on a label element inside its template #4741

Closed
marin-bratanov opened this issue Jan 7, 2019 · 5 comments
Assignees
Labels
Bug C: PanelBar FP: Completed Sync status with associated Feedback Item jQuery SEV: High
Milestone

Comments

@marin-bratanov
Copy link
Contributor

Bug report

When you place a <label> inside the template of a panelbar, and click on that label, the select event fires twice instead of the expected once.

Note: works as expected on collapsible items, only items without children exhibit the problem.

Reported in Ticket ID: 1381775

May be related to #2761 and #2752

Reproduction of the problem

reproducible: https://dojo.telerik.com/OXazIKUq

Expected/desired behavior

the event keeps firing only once as if you clicked on any place in the item outside of the label.

Environment

  • Kendo UI version: 2018.3.1017
  • jQuery version: 1.12.4
  • Browser: all
@marin-bratanov
Copy link
Contributor Author

One possible workaround https://dojo.telerik.com/@bratanov/otIVuNag

@marin-bratanov
Copy link
Contributor Author

@Juveniel Juveniel self-assigned this Oct 15, 2019
@nenchef nenchef added the FP: Planned Sync status with associated Feedback Item label Oct 15, 2019
@kendo-bot kendo-bot added FP: In Development Sync status with associated Feedback Item and removed FP: Planned Sync status with associated Feedback Item labels Oct 15, 2019
@Dimitar-Goshev Dimitar-Goshev changed the title PanelBar fires onSelect twice if you click on a <label> inside its template PanelBar fires onSelect twice if you click on a label element inside its template Oct 28, 2019
@Dimitar-Goshev
Copy link
Contributor

@Juveniel After the fix expanding clicking on a PanelBar item with contentUrl navigates to that URL. Also it is not possible anymore to expand such an item with keyboard Enter/Space key.
To reproduce the issue, use panelbar/ajax demo (all items) or panelbar/events demo (Ajax Item and Error Item)

@Juveniel Juveniel added this to the R1 2020 milestone Nov 4, 2019
@Dimitar-Goshev
Copy link
Contributor

@Juveniel After the second fix, it is not possible to expand PanelBar item with contentUrl at all (clicking on it or through keyboard). Use kendo-ui/panelbar/ajax demo for reproduction.

@Dimitar-Goshev
Copy link
Contributor

@Juveniel Clicking on the expand arrow icon of a PanelBar item with contentUrl navigates to that URL.

@kendo-bot kendo-bot added FP: Completed Sync status with associated Feedback Item and removed FP: In Development Sync status with associated Feedback Item labels Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug C: PanelBar FP: Completed Sync status with associated Feedback Item jQuery SEV: High
Projects
None yet
Development

No branches or pull requests

6 participants