Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

added logging when executing system commands #867

Merged
merged 1 commit into from
Jan 17, 2017

Conversation

Plamen5kov
Copy link
Contributor

Cli executes system commands, but when they are not critical for the system the OS works fine, but cli fails because it can't find the necessary commands it expects to be there by default. Added some logging for easier tracing in the future.
related: NativeScript/nativescript-cli#1922

@justcodebuilduser
Copy link

❤️

@Plamen5kov Plamen5kov self-assigned this Jan 6, 2017
Copy link
Collaborator

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$logger.error is not suitable as sysInfo gathers a lot of information. We are not sure we should bother user with everything that we can find. However I believe we need such logs, so $logger.trace seems perfect for me.

@justcodebuilduser
Copy link

❤️

@Plamen5kov
Copy link
Contributor Author

@rosen-vladimirov the changes you requested are done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants