FreeBSD compile fixes #6
Conversation
If config file(s) did not exist, cfg/var_cfg was not inited. This caused segfault in destructor
In distributed .tar.gz, there is no Doxyfile.in, which CMake chokes on.
This works on 9.x aswell, not sure about Linux though so keeping in ifdefs. Note: To actually compile on FreeBSD 10.0 using clang, additional patch is required. Not sure how do do that cleanly though, so keeping it in FreeBSD port for now.. More specifically, in common/Event.h, ::tr1 needs to be removed since FreeBSD 10/clang has this in c++11 base std:: now, instead of std::tr1 sub-namespace.
|
A note on 10.0 compilation: common/Event.h uses "std::tr1::shared_ptr". In FreeBSD 10, the clang compiler is used with some c++ 11 impl which does not provide this pre-11 syntax. Instead, it provides std::shared_ptr (since it is a real c++11 impl). So, I guess it boils down to, telldus-core does not compile on, at least some, C++11 platforms. However, I'm not sure, at all, how to solve this in a portable way.. Ref: https://forums.freebsd.org/viewtopic.php?f=46&t=12553&p=258396#p258295 |
|
We would like to merge this. Unfortunately commit 1f8f4b6 does not conform to our coding style guidlines. |
10.1 does not have WCHAR_T_ENCODING, which results in empty strings from TelldusCore::wideToString Ref: http://developer.telldus.com/ticket/399
This is not recommended, but works. Without this fix, we get link error since clang uses extra header rather than system header, and without link flags we fail.
|
Code style fixes has been added. |
The previous one used $port erronously, it just happened to be right when I tested. This patch works around a bug in uftdi/devd, which has been reported upstream.
|
Is there still something wrong with this pull request, after it was adjusted for coding style? |
Minor fixes to build latest version on FreeBSD.
Also fix for non-init variable usage.