updated to latest version #2
Conversation
added list origin identities, create origin identities fixed update distribution config added signedUrl generation for canned policy
|
This looks great. I have not had the need for private content yet, so I left out the bit when I wrote this. I will probably not have time to look at it until Monday, but will try to merge and pushed it to NPM then. |
|
Looking forward for your feedback and 0.1.2 version ;) |
| Enabled: config.enabled, | ||
| DefaultRootObject: config.defaultRootObject | ||
| Comment: config.comment || '', | ||
| Enabled: config.enabled |
There was a problem hiding this comment.
Maybe it should have been !!config.enabled so we are certain that it is a boolean.
There was a problem hiding this comment.
You can change it, if you like
There was a problem hiding this comment.
Probably I'll do it after merging.
|
I see you've fixed some bugs that I have overlooked. Self I use it only to retrieve information from the CloudFront, as thus is the put / post / delete functionality untested. It should perhaps have been written a test suite. I see you also have some indentation errors. I use two spaces. I look forward to your responses to my comments as well :) |
removed url dependency use 2 spaces indentation
|
Fixed indentation overall the file, removed console.log, removed url module usage |
| CallerReference: callerReference, | ||
| Comment: comment || '' | ||
| }); | ||
| } |
|
Do you use an automatic tool to fix the indentation? You have edited quite a bit. |
|
Yes, used TextMate |
|
I've added a Since this method implements everything that I have also implemented the rest of the OAI methods ( |
|
Looks good, but I think there're too much ways to parse getPrivateUrl :). Did you push changes to npm? |
|
Probably a little many, but I imagine just to document a few of them. I push it to npm today.
|
|
I think |
Hi,
Updated your code to my own needs. Maybe you find it useful for yourself as well.
Regards,
Alex