Skip to content
This repository has been archived by the owner on Dec 4, 2018. It is now read-only.

Instructions to get it working in UITableViewController #11

Closed
magnett opened this issue Jul 12, 2014 · 13 comments
Closed

Instructions to get it working in UITableViewController #11

magnett opened this issue Jul 12, 2014 · 13 comments
Labels

Comments

@magnett
Copy link

magnett commented Jul 12, 2014

Hi!
Thanks for this control, truly great work!
In my case, the screenshot you see below is from a UITableViewController. The position of the drawer is wrong and i can not scroll the whole table. I made an experiment and used a UIVIewController and everything worked smoothly.
Is anything special i can do to get it working with a UITableViewController?
ios simulator screen shot jul 12 2014 20 00 46

@Mazyod
Copy link
Contributor

Mazyod commented Jul 12, 2014

Thanks for reporting the problem!
The issue is that the component tries to add the extension view as a subview of associated view controller, which is in your case, a UITableViewController. This means the extension view is being added as a subview of a UITableView, which screws everything up.

I am looking into a better solution now that should help resolve this problem.

@Mazyod
Copy link
Contributor

Mazyod commented Jul 12, 2014

Apparently, if you access self.topLayoutGuide on UITableViewController, everything screws up... I don't know why..

@insanj
Copy link

insanj commented Jul 15, 2014

Checking in to report this problem as well. Implementing the example setups in a UITableViewController prevents any scrolling expect for elastic/bounce, and doesn't work as intended. No combination of existing controller and tableView seem to work, and I haven't accessed the self.topLayoutGuide property anywhere in my codebase.

@Mazyod
Copy link
Contributor

Mazyod commented Jul 16, 2014

@insanj The access to topLayoutGuide is made from within the component, and is quite necessary.

@insanj
Copy link

insanj commented Jul 16, 2014

@Mazyod Ah, I didn't realize that. My knowledge of the underworkings of UITableViewControllers feels quite barren, now! Excited to use TLYShyNavBar in production once this gets resolved.

@Mazyod
Copy link
Contributor

Mazyod commented Jul 16, 2014

@insanj Oh, sorry no. I meant used within the TLYShyNavBar component, not UITableViewController. I will hopefully look into this soon, but you can try what another user did, he migrated to a UIViewController, and added the tableView as a subview. If you can't or prefer to use UITableViewController, that's cool, too. I just need some time to look into it. It's unfortunately not straight forward.

@insanj
Copy link

insanj commented Jul 16, 2014

@Mazyod Thanks for the clarification. That's actually how I initially structured the view controller in question, but I migrated to using a UITableViewController to utilize refreshControl more conveniently. It might be worth going backwards for the performance and beauty of TLYShyNavBar, though. Thanks for your efforts, either way.

@Mazyod Mazyod added the bug label Aug 3, 2014
@basilmariano
Copy link

Hi,

@Mazyod , I really like your very nice library and actuallyI am using it now in my current project :)
But there is a problem on pushViewController, the extensionView shows when I push, but it is actually hidden..

I saw your .gif sample, it works well in GIF but in actual implemetation it doesn't, I dont know what I am doing wrong. Can you pls help me master

@jodyheavener
Copy link

Any progress on this? Would love to get this working with my UITableViewController as I can't do the recommended approach of adding a UITableView to UIViewController

@Mazyod
Copy link
Contributor

Mazyod commented Sep 29, 2014

@jodyheavener Personally, I can't justify spending work hours on this project for the time being, since we are not using the component this way. On the side, I can't find time to develop it. Of course, since this is a very demanded feature, I'll do my best to review any PRs on this front ASAP, and give feedback as well as discuss it, if necessary. I'm available on twitter @Mazyod.

@Mazyod
Copy link
Contributor

Mazyod commented Apr 4, 2015

Since the repo has a UITableViewController example now, I suppose this issue should be closed. If there are any more specific issues, please reopen or specify the exact issue

@Mazyod Mazyod closed this as completed Apr 4, 2015
@rrallo
Copy link

rrallo commented May 21, 2015

So is the only workaround to migrate to a ViewController with a tableview inside of it? This issue only happens to me on iOS 7.1.

Amazing job on the repo though!

@yuchaozh
Copy link

yuchaozh commented Sep 9, 2015

I met the same issue right now. Where is the example for UITableViewController?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

7 participants