Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to use tvg-id tags for channel numbering #67

Closed
wants to merge 3 commits into from
Closed

Conversation

hazcod
Copy link
Contributor

@hazcod hazcod commented Mar 10, 2018

Try to use tvg-id tags for channel numbering

Fixes #63

Still needs to be tested

main.go Outdated
channNum = strconv.Itoa(gn)
gn += 1
} else {
channNum = track.TvgID
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make sure Plex allows non-int strings as a channel number because in my m3u the Tvg ID is something like "BBCOne.UK"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, i've only seen non-integer ones so far in my playlists as wel.
Testing will point out.

@tombowditch
Copy link
Collaborator

Will test this tonight.

@hazcod
Copy link
Contributor Author

hazcod commented Mar 16, 2018

Did you have a chance to test this? I don't have Plex or M3U streams available at the moment :(

@tombowditch
Copy link
Collaborator

Indeed I did - Plex does not like the non-integer strings. I propse if a strconv.Atoi (iirc) fails we just use gn

@tombowditch tombowditch added this to To do in telly Mar 16, 2018
@tombowditch tombowditch moved this from To do to In progress in telly Mar 16, 2018
@tombowditch tombowditch removed this from In progress in telly Mar 16, 2018
@hazcod
Copy link
Contributor Author

hazcod commented Mar 22, 2018

I added the check @tombowditch , altough I do suggest (after merging?) that we take a deeper look at how this whole tvg-id tag system works.

Edit: it seems that Plex always expects channel numbers to be numbers and those are IDs in format tvg-id="RaiNews.it". I suggest we take XML EPG as an input and parse the channel numbers out of that.

@tombowditch
Copy link
Collaborator

Agreed @hazcod we need to ask for the providers XML and parse that.
For a fallback we can continue to use gn

@tombowditch
Copy link
Collaborator

#72 will also be handy

@hazcod
Copy link
Contributor Author

hazcod commented Mar 22, 2018

@tombowditch what do you think about my sketchy implementation?
It's done in 10 minutes, but should give a raw idea about how we could do things.

@robbiet480
Copy link
Member

I've rebased this on master. Can I get push access to be able to maintain this PR? I pinged both of you (well, I tried to ping you @hazcod but there were like 10 accounts) on Discord if you need to chat.

@robbiet480
Copy link
Member

Rebase is now on my fork

@hazcod
Copy link
Contributor Author

hazcod commented Aug 10, 2018

I will take a look at it tomorrow, thanks! Im not on Discord often.

@robbiet480
Copy link
Member

Closing in favor of changes described in #142 and available in the new dev branch.

@robbiet480 robbiet480 closed this Aug 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants