-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to use tvg-id tags for channel numbering #67
Conversation
main.go
Outdated
channNum = strconv.Itoa(gn) | ||
gn += 1 | ||
} else { | ||
channNum = track.TvgID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to make sure Plex allows non-int strings as a channel number because in my m3u the Tvg ID is something like "BBCOne.UK"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, i've only seen non-integer ones so far in my playlists as wel.
Testing will point out.
Will test this tonight. |
Did you have a chance to test this? I don't have Plex or M3U streams available at the moment :( |
Indeed I did - Plex does not like the non-integer strings. I propse if a strconv.Atoi (iirc) fails we just use |
I added the check @tombowditch , altough I do suggest (after merging?) that we take a deeper look at how this whole Edit: it seems that Plex always expects channel numbers to be numbers and those are IDs in format |
Agreed @hazcod we need to ask for the providers XML and parse that. |
#72 will also be handy |
@tombowditch what do you think about my sketchy implementation? |
I've rebased this on master. Can I get push access to be able to maintain this PR? I pinged both of you (well, I tried to ping you @hazcod but there were like 10 accounts) on Discord if you need to chat. |
Rebase is now on my fork |
I will take a look at it tomorrow, thanks! Im not on Discord often. |
Closing in favor of changes described in #142 and available in the new |
Try to use tvg-id tags for channel numbering
Fixes #63
Still needs to be tested