Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk format parameter is ignored #147

Closed
pupaxxo opened this issue Nov 22, 2021 · 0 comments · Fixed by #148
Closed

Disk format parameter is ignored #147

pupaxxo opened this issue Nov 22, 2021 · 0 comments · Fixed by #148

Comments

@pupaxxo
Copy link
Contributor

pupaxxo commented Nov 22, 2021

In config_qemu format disk parameter is ignored and not sent:

https://github.com/Telmate/proxmox-api-go/blob/master/proxmox/config_qemu.go#L1088

	// Keys that are not used as real/direct conf.
	ignoredKeys := []string{"key", "slot", "type", "storage", "file", "size", "cache", "volume", "container", "vm", "mountoptions", "storage_type", "format"}

	// Rest of config.
	diskConfParam = diskConfParam.createDeviceParam(disk, ignoredKeys)

I'm using packer to create vms and disks are created only in raw format.

Why is it ignored? Is it a bug/typo?

pupaxxo added a commit to pupaxxo/proxmox-api-go that referenced this issue Nov 23, 2021
frostyfab pushed a commit to frostyfab/proxmox-api-go that referenced this issue Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant