Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - token page: adjust the visual behavior of the token-detail component to look nice in every context used #54

Closed
Tracked by #16
Viterbo opened this issue Sep 7, 2022 · 3 comments
Assignees
Labels
🎯 Feature New feature or request

Comments

@Viterbo
Copy link
Collaborator

Viterbo commented Sep 7, 2022

No description provided.

@Viterbo Viterbo mentioned this issue Sep 7, 2022
7 tasks
@Viterbo Viterbo self-assigned this Sep 7, 2022
@Viterbo
Copy link
Collaborator Author

Viterbo commented Sep 7, 2022

The same component is used in two places its behavior is not adequate or can be imprived.

Following the screen shots shows 3 issues with the visual behavior:

1 - When listing tokens the token-display component shows even when it has nothing to show

token-detail-1

2 - When there's a token selected it displays a huge card instead of a medium tall wide nice card.

token-detail-2

3 - The creating a new token the component adjusts its width to the content. This generates a not desired visual effect moving the form to the left as the user writes.

token-detail-3

@Viterbo Viterbo added the 🎯 Feature New feature or request label Sep 7, 2022
Viterbo added a commit that referenced this issue Sep 9, 2022
@Viterbo
Copy link
Collaborator Author

Viterbo commented Sep 9, 2022

This commit 55685db changes the token-detail component and also changes the way it is used.

1.1 - Here is showing the token details on the tokens' main page. It also has a mini animation of fading in and out.

token-detail-fix-1

1.2 - Here is the same situation but the token owner is logged, so the edit button is shown instead of just jumping into the edition form.

token-detail-fix-2

2.1 - Here we are editing the token. Now the token preview is on the top instead of being on the side. This generates a very large scrollable page which is not desirable, so I split the form interaction into two parts: This screenshot shows the first part.

token-edit-form-fix-1

2.2 - This screenshot shows the situation right after accepting the terms. There's a mini animation of fading in and out.

token-edit-form-fix-2

3 - Finally, the creation form shows a non-empty token-detail component showing a placeholder while the fields are still empty.

token-edit-form-fix-3

@Viterbo Viterbo mentioned this issue Sep 9, 2022
@Viterbo
Copy link
Collaborator Author

Viterbo commented Sep 19, 2022

I close this issue because is fixed and merged.

@Viterbo Viterbo closed this as completed Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 Feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant