Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voters list requires page reload #295 #333

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

TusharKarkera22
Copy link
Contributor

Voters list requires page reload #295

Description

Voted tag only shows up if you've cast your vote and I made sure it hides when you haven't. I also included some code to manage its visibility smoothly without the need for a page reload.

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for telos-app-native-testnet ready!

Name Link
🔨 Latest commit 012429d
🔍 Latest deploy log https://app.netlify.com/sites/telos-app-native-testnet/deploys/66127ae1b5e8dc00080d094e
😎 Deploy Preview https://deploy-preview-333--telos-app-native-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for telos-app-native-mainnet ready!

Name Link
🔨 Latest commit 012429d
🔍 Latest deploy log https://app.netlify.com/sites/telos-app-native-mainnet/deploys/66127ae10186260008ac9e57
😎 Deploy Preview https://deploy-preview-333--telos-app-native-mainnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@donnyquixotic donnyquixotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It incorrectly displays the 'vote' tag if vote transaction fails and account list is not updating on successful vote requiring page refresh. You can test by voting on a proposal using the testnet deployment: https://deploy-preview-333--telos-app-native-testnet.netlify.app/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants