Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account header flags #760

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Account header flags #760

merged 3 commits into from
Oct 3, 2023

Conversation

karynemayer
Copy link
Collaborator

Description

This PR includes feature flags around the header functionalities, so any chain can choose more easily what features they want to provide.

Test scenarios

The changes on this PR should not cause any behavioral change on any of the current chains.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit 3eb5885
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/65174b3d81342000084c0eda
😎 Deploy Preview https://deploy-preview-760--obe-testnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for obe-staging ready!

Name Link
🔨 Latest commit 3eb5885
🔍 Latest deploy log https://app.netlify.com/sites/obe-staging/deploys/65174b3d3e5d330007bb180b
😎 Deploy Preview https://deploy-preview-760--obe-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@poplexity poplexity merged commit 172ffa1 into develop Oct 3, 2023
10 checks passed
@poplexity poplexity deleted the account-header-flags branch October 3, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants