Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including local storage as fallback #762

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Including local storage as fallback #762

merged 1 commit into from
Oct 3, 2023

Conversation

karynemayer
Copy link
Collaborator

Fixes #issue_number

Description

The router wasn't taking into consideration the current chain for urls that come from the application itself, which don't have the network in the path.

Current changes just make sure that if we have a current chain selected in the current session, we continue to use that before falling back to the preferred chain.

Note that this would be a great candidate for a refactor, which will be addressed in future PR.

Test scenarios

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit 27bd804
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/651a58fe9a0d1f000855f2c5
😎 Deploy Preview https://deploy-preview-762--obe-testnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for obe-staging ready!

Name Link
🔨 Latest commit 27bd804
🔍 Latest deploy log https://app.netlify.com/sites/obe-staging/deploys/651a58fe8921430008ff2e6e
😎 Deploy Preview https://deploy-preview-762--obe-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 27bd804
Status: ✅  Deploy successful!
Preview URL: https://119a855e.open-block-explorer.pages.dev
Branch Preview URL: https://hotfix-router.open-block-explorer.pages.dev

View logs

@poplexity poplexity merged commit 38dfcbe into develop Oct 3, 2023
10 checks passed
@poplexity poplexity deleted the hotfix-router branch October 3, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants