Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decimal place for any token under 1 USD #787

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

kylanhurt
Copy link
Contributor

Fixes #784

Description

It checks the price and if it is under 1 USD then it adds an extra decimal (3 instead of 2). Relevant for current TLOS price.

Test scenarios

Checked on desktop and mobile

image

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for open-block-explorer ready!

Name Link
🔨 Latest commit 4c87d8e
🔍 Latest deploy log https://app.netlify.com/sites/open-block-explorer/deploys/653052309afb380009c686b6
😎 Deploy Preview https://deploy-preview-787--open-block-explorer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit 4c87d8e
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/65305230c66028000846e456
😎 Deploy Preview https://deploy-preview-787--obe-testnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@donnyquixotic donnyquixotic changed the base branch from master to develop October 18, 2023 22:30
@donnyquixotic donnyquixotic merged commit 545738a into develop Oct 18, 2023
10 checks passed
@donnyquixotic donnyquixotic deleted the 784-tlos-extra-decimal branch October 18, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homepage price should have extra decimal when necessary
2 participants