Implement localStorage saving of tx pagination batch size #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for obe-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for obe-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying with
|
| Latest commit: |
c2f5174
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c1170ba6.open-block-explorer.pages.dev |
| Branch Preview URL: | https://820-local-storage.open-block-explorer.pages.dev |
kylanhurt
force-pushed
the
820-local-storage
branch
from
6bb8c60
to
077ef5e
Compare
Remove unnecessary console log Remove unnecessary localStorage.removeItem Add useful comments for tx pagination localStorage routine Get transaction table rows per page to defer to url params
kylanhurt
force-pushed
the
820-local-storage
branch
from
077ef5e
to
c2f5174
Compare
donnyquixotic
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary console log
Fixes #820
Description
Used
localStorageto set user's preference for how many txs per "page". IflocalStoragevalue is ever invalid it will replace it with a valid value (smallest option, currently10). URL query params take precedence overlocalStoragevalueTest scenarios
Go to homepage and start changing the items per page value. Removing params from URL and reloading should show saved setting # of transactions. Keeping query params in URL should have those params take precedence over user setting.
Checklist: