Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paginate by action #861

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

pmjanus
Copy link
Contributor

@pmjanus pmjanus commented Jun 22, 2024

Fixes #860

Description

Paginates transaction table by actions, since each row is an action that references a transaction, we will show 10 or whatever number selected of rows per page instead of all actions for a single transaction.

Test scenarios

Verify that block pages are paginating accurately, try blocks around :1289 and newer blocks as well as any blocks you might have knowledge of being special in any way.
Verify filters are working at least as well as in the production release, create a separate issue for any issues found here that are also present in release.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage
  • I have updated relevant documentation and/or opened a separate issue to cover the updates (Issue URL: )

Copy link

netlify bot commented Jun 22, 2024

Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit 9583040
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/6676e55b5e61a00009397f3d
😎 Deploy Preview https://deploy-preview-861--obe-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 22, 2024

Deploy Preview for open-block-explorer ready!

Name Link
🔨 Latest commit 9583040
🔍 Latest deploy log https://app.netlify.com/sites/open-block-explorer/deploys/6676e55c0ac47b00081e11f0
😎 Deploy Preview https://deploy-preview-861--open-block-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG- Pagination ignored on block page transactions.
2 participants