You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Presently, styles are fragmented between Sass and SCSS formats. In order to make the codebase more in line with the Vue / web frontend community at large, as well as to make the codebase consistent, styles should be migrated to be in Sass format. Additionally, style files should be arranged in a logical fashion, such that a new developer could find what they need simply by looking at the repo's file structure.
Acceptance criteria
a new Issue should be created to refactor styles into a standardized directory structure which is determined as a part of this Issue (see Technical Considerations)
implementation of directory re-structure is out of scope for this issue
all .sass files should be replaced with a .scss file
style cleanup is out of scope for this issue
all Sass styles in the repo should be replaced with SCSS syntax
there should be no remaining instances of <style lang="sass"> in SFCs
an ESLint rule should be added to enforce style syntax if possible
legacy (for temporary placement of existing styles in need of refactor - implementation of which should be handled in a separate Issue from the directory restructure)
modules (for components which span multiple SFCs and thus cannot rely on SFC <style> tags)
a utility(s) should likely be used to migrate formats from sass to SCSS
if the webpack loaders for sass and scss are not the same, sass loader should be removed
Tasks
The text was updated successfully, but these errors were encountered:
Overview
Presently, styles are fragmented between Sass and SCSS formats. In order to make the codebase more in line with the Vue / web frontend community at large, as well as to make the codebase consistent, styles should be migrated to be in Sass format. Additionally, style files should be arranged in a logical fashion, such that a new developer could find what they need simply by looking at the repo's file structure.
Acceptance criteria
.sass
files should be replaced with a.scss
file<style lang="sass">
in SFCsTechnical considerations
typography
variables
(color, spacers,overrides
(for overriding library/plugin/framework styles)legacy
(for temporary placement of existing styles in need of refactor - implementation of which should be handled in a separate Issue from the directory restructure)modules
(for components which span multiple SFCs and thus cannot rely on SFC<style>
tags)sass
andscss
are not the same,sass
loader should be removedTasks
The text was updated successfully, but these errors were encountered: