Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style selectors cleanup #137

Open
ezra-sg opened this issue Sep 10, 2022 · 0 comments
Open

Style selectors cleanup #137

ezra-sg opened this issue Sep 10, 2022 · 0 comments
Labels
🚫 Blocked Work cannot be done until blocker is resolved 🔧 Tech Debt Refactoring, library upgrades, documentation

Comments

@ezra-sg
Copy link
Contributor

ezra-sg commented Sep 10, 2022

Blocked by #136

Overview

Currently, many selectors throughout the site are unnecessarily specific, leading to unexpected failures of local styles (in a component's script tag) to take effect. additionally, many styles use selectors which are not namespaced in any way, leading to many opportunities for style bleeding

Acceptance criteria

  • styles in app-wide stylesheets, ie. in css/
  • component styles should be converted to BEM where relatively easy; otherwise (unlikely) SFC style tags should be set to scoped and a comment should be left in the style tag indicating the styles are deprecated (ie. it should be easy for new devs to see where styles do not reflect the standards held for the site in general)
  • remove all scoped styles where easily possible

Technical considerations

N/A

Tasks

@ezra-sg ezra-sg added 🔧 Tech Debt Refactoring, library upgrades, documentation 🚫 Blocked Work cannot be done until blocker is resolved labels Sep 10, 2022
@ezra-sg ezra-sg added 🔬 Needs Refinement Further information is required and removed 🔬 Needs Refinement Further information is required labels Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚫 Blocked Work cannot be done until blocker is resolved 🔧 Tech Debt Refactoring, library upgrades, documentation
Projects
None yet
Development

No branches or pull requests

1 participant