(Breaking) Improvements and Fixes #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: decimal module did not have exlusively `Decimal` related definitions. Therefore, the module is renamed to numeric.
BREAKING CHANGE: Adjective usage is more proper than noun usage, like that we are using numeric for the module that deals with numbers.
BREAKING CHANGE: Adjective usage is more proper than noun usage, like that we are using numeric for the module that deals with numbers and textual for the module that deals with texts.
BREAKING CHANGE: Adjective usage is more proper than noun usage. Also, this module will eventually introduce more definitions which are not coming from purify.ts.
Closes #34.
BREAKING CHANGE: We have refactored the names AND the semantics of our finite, arbitrary precision number constructors. Now, there are two constuctors: 1. `decimal`, a smart constructor that fails with `Nothing`. 2. `unsafeDecimal`, uses `decimal` but throws when `Nothing`. Now, both constructors consume `number` or `string` values but won't consume `null` or `undefined`. They will both fail on invalid AND infinite values (such as `NaN`, `Infinity` and `-Infinity`. Closes #35. Closes #36. Closes #37.
vst
added
breaking
|
👀 |
alioguzhan
approved these changes
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces breaking improvements and fixes. Once merged and released, dependent call-sites will need careful refactoring.