sharp-quote function symbol #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
riscy
reviewed
Jan 28, 2024
| @@ -474,9 +474,9 @@ This produces the URL variant of base 64 encoding defined in RFC 4648. | |||
|
|
|||
| Exists because this package is compatible with Emacs 26.1, but | |||
| ‘base64url-encode-string’ was only added in Emacs 27.1." | |||
| (if (fboundp 'base64url-encode-string) | |||
| (if (fboundp #'base64url-encode-string) | |||
There was a problem hiding this comment.
I think you want to leave it as a regular quote here (since at this point we don't even know if this symbol is a function, let alone bound).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.