Choose scopes and a little bit of testing #9
Conversation
| ;; Version: 0.1 | ||
| ;; Keywords: comm oauth2 | ||
| ;; Maintainer: Adrià Garriga-Alonso <adria@rdwrs.com> | ||
| ;; Version: 0.0.1 |
There was a problem hiding this comment.
Why are you changing the version to a smaller version here?
According to semver, patch changes (changing z in x.y.z) should be used only for bug fixes. This seems more appropriate for a version 0.2.0.
There was a problem hiding this comment.
Yeah, you're probably right, I'll change this to 0.2.0
| "Default client ID for Google OAuth2." | ||
| :group 'oauth2-auto | ||
| :type 'string) | ||
|
|
||
| (defcustom oauth2-auto-google-client-secret "" | ||
| (defcustom oauth2-auto-google-client-secret "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" |
There was a problem hiding this comment.
Will it work to embed this in a widely-distributed library?
There was a problem hiding this comment.
I've heard it's OK. There's no way to avoid embedding the app key if you're distributing a program.
I still have to do the verification process so for now it's not very useful
There was a problem hiding this comment.
@rhaps0dy Is there any progress on the verification program? If not, we'll have to resort to having clients make their own apps on the Google Developer Console.
There was a problem hiding this comment.
Hello @telotortium ,
You might have guessed from the lack of reply, but sorry, there hasn't been :(. I don't think I'll have the time and motivation to do this either, I'm not using Oauth on Emacs any more. Would you like me to transfer the repo to you or something?
There was a problem hiding this comment.
@rhaps0dy Yes, I can take it over and improve it to the point where I can fix any bugs. We probably won't get it approved by Google, but making personal apps is sufficient for org-gcal and other apps like that.
There was a problem hiding this comment.
@rhaps0dy Tracking transferring the repo on https://github.com/rhaps0dy/emacs-oauth2-auto/issues/12
To get the library Google-approved, I've decided that making the requestable scopes modular will be useful.
Here's also some tests, though not complete. That is a step towards MELPA approval.