Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in errors.rs ToMuchMessages #1046

Merged
merged 5 commits into from
Apr 12, 2024
Merged

fix: typo in errors.rs ToMuchMessages #1046

merged 5 commits into from
Apr 12, 2024

Conversation

mhkafadar
Copy link
Contributor

@mhkafadar mhkafadar commented Apr 12, 2024 •
edited
Loading

There was a missing 'o' in TooMuchMessages naming.

@teloxidebot
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @WaffleLapkin (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @teloxidebot author: the review is finished, PR author should check the comments and take action accordingly
  • @teloxidebot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@teloxidebot teloxidebot added A-tba-errors Area: representation of telegram bot API errors C-core crate: teloxide-core S-waiting-on-review Status: Awaiting review from the assignee labels Apr 12, 2024
WaffleLapkin
WaffleLapkin requested changes Apr 12, 2024
View reviewed changes
Copy link
Member

@WaffleLapkin WaffleLapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo the Cargo.lock changes and add a changelog entry.

@teloxidebot teloxidebot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author and removed S-waiting-on-review Status: Awaiting review from the assignee labels Apr 12, 2024
@teloxidebot teloxidebot added S-waiting-on-review Status: Awaiting review from the assignee and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author labels Apr 12, 2024
@mhkafadar
Copy link
Contributor Author

Hello! @WaffleLapkin I've updated the PR. Thank you!

WaffleLapkin
WaffleLapkin reviewed Apr 12, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
WaffleLapkin
WaffleLapkin approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@WaffleLapkin WaffleLapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@WaffleLapkin WaffleLapkin added this pull request to the merge queue Apr 12, 2024
Merged via the queue into teloxide:master with commit 384811a Apr 12, 2024
9 checks passed
@mhkafadar mhkafadar deleted the fix/typo-in-errors branch April 12, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

Assignees

@WaffleLapkin WaffleLapkin

Labels
A-tba-errors Area: representation of telegram bot API errors C-core crate: teloxide-core S-waiting-on-review Status: Awaiting review from the assignee
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mhkafadar @teloxidebot @WaffleLapkin