Force WorkerBolt to be more strict with stored data
#2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitacherevko
approved these changes
Jun 26, 2019
surabujin
force-pushed
the
hs-worker-timeout-handling-fix
branch
from
d28eedd
to
4dbaafa
Compare
surabujin
force-pushed
the
hs-worker-timeout-handling-fix
branch
2 times, most recently
from
00961f9
to
ecb7805
Compare
surabujin
force-pushed
the
hs-worker-timeout-handling-fix
branch
from
ecb7805
to
32c20d3
Compare
surabujin
force-pushed
the
hs-worker-timeout-handling-fix
branch
from
32c20d3
to
76670d0
Compare
surabujin
force-pushed
the
hs-worker-timeout-handling-fix
branch
from
76670d0
to
cf5302f
Compare
Lock all operations with `pendingTasks` map into the `WorkerBolt` i.e. do not allow access there to the inheritors. If inheritors have access to this map there is no way to implement LCM for objects stored there. The original problem was lack of cleanup on timeout action. Also make correct routing/dispatching of `onTimeout` event, till now this dispach have happended inside `dispatch` method of `org.openkilda.wfm.share.hubandspoke.CoordinatedBolt`(happens before `handleInput`) as result all checks and cleanup steps implemented on `handleInput` level are skipped.
surabujin
force-pushed
the
hs-worker-timeout-handling-fix
branch
from
cf5302f
to
7941204
Compare
surabujin
requested review from
sergii-iakovenko,
dpoltavets,
nikitamarchenko and
timofei-durakov
nikitamarchenko
approved these changes
Sep 12, 2019
There was a problem hiding this comment.
Reviewed 13 of 13 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dpoltavets, @niksv, @sergii-iakovenko, and @timofei-durakov)
dpoltavets
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock all operations with
pendingTasksmap into theWorkerBolti.e.do not allow access there to the inheritors. If inheritors have access
to this map there is no way to implement LCM for objects stored there.
The original problem was lack of cleanup on timeout action.
Also make correct routing/dispatching of
onTimeoutevent, till nowthis dispach have happended inside
dispatchmethod oforg.openkilda.wfm.share.hubandspoke.CoordinatedBolt(happens beforehandleInput) as result all checks and cleanup steps implemented onhandleInputlevel are skipped.This change is