Add connected devices traffgen support to testing framework #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtretyak
changed the title
rtretyak
force-pushed
the
functional/connected_devices_traffgen
branch
2 times, most recently
from
402b3c7
to
8a5a969
Compare
andriidovhan
approved these changes
Sep 3, 2019
niksv
approved these changes
Sep 3, 2019
niksv
force-pushed
the
connected
branch
6 times, most recently
from
819409e
to
d44de56
Compare
rtretyak
force-pushed
the
functional/connected_devices_traffgen
branch
3 times, most recently
from
15db525
to
e999e81
Compare
niksv
force-pushed
the
functional/connected_devices_traffgen
branch
from
e999e81
to
33189ef
Compare
rtretyak
force-pushed
the
functional/connected_devices_traffgen
branch
3 times, most recently
from
ef058b7
to
385d3d9
Compare
|
Note the target branch. Merge before merging |
rtretyak
force-pushed
the
functional/connected_devices_traffgen
branch
from
0d5d761
to
070c234
Compare
...ests/src/test/groovy/org/openkilda/functionaltests/spec/flows/FlowConnectedDeviceSpec.groovy
Outdated
Show resolved
Hide resolved
...ests/src/test/groovy/org/openkilda/functionaltests/spec/flows/FlowConnectedDeviceSpec.groovy
Show resolved
Hide resolved
...ests/src/test/groovy/org/openkilda/functionaltests/spec/flows/FlowConnectedDeviceSpec.groovy
Outdated
Show resolved
Hide resolved
...ests/src/test/groovy/org/openkilda/functionaltests/spec/flows/FlowConnectedDeviceSpec.groovy
Show resolved
Hide resolved
...ests/src/test/groovy/org/openkilda/functionaltests/spec/switches/SwitchValidationSpec.groovy
Outdated
Show resolved
Hide resolved
...ests/src/test/groovy/org/openkilda/functionaltests/spec/switches/SwitchValidationSpec.groovy
Outdated
Show resolved
Hide resolved
...s/src/test-library/src/main/java/org/openkilda/testing/service/traffexam/model/LldpData.java
Show resolved
Hide resolved
niksv
force-pushed
the
functional/connected_devices_traffgen
branch
from
070c234
to
4da8265
Compare
niksv
force-pushed
the
connected
branch
2 times, most recently
from
6cd5bba
to
ba7bd7f
Compare
niksv
force-pushed
the
functional/connected_devices_traffgen
branch
from
4da8265
to
f29db12
Compare
rtretyak
force-pushed
the
functional/connected_devices_traffgen
branch
from
f29db12
to
83095bc
Compare
niksv
force-pushed
the
functional/connected_devices_traffgen
branch
2 times, most recently
from
1ac3236
to
ed9ce39
Compare
niksv
force-pushed
the
functional/connected_devices_traffgen
branch
from
ed9ce39
to
e47081d
Compare
andriidovhan
approved these changes
Sep 18, 2019
| involvedSwitches[1..-1].each { switchId -> | ||
| northbound.deleteSwitchRules(switchId, DeleteRulesAction.IGNORE_DEFAULTS) | ||
| when: "Synchronize the switch" | ||
| verifyAll(northbound.synchronizeSwitch(switchPair.src.dpId, false)) { |
There was a problem hiding this comment.
northbound.synchronizeSwitch(switchPair.src.dpId, false).rules.installed == [egressCookie]
There was a problem hiding this comment.
this is a mistake. with and verifyAll are forcing the verification in 'when' block. So it was correct. Your option is missing an assert keyword
There was a problem hiding this comment.
All related comments are reverted to this style:
when: "Synchronize the switch"
with(northbound.synchronizeSwitch(switchPair.src.dpId, false)) {
rules.installed == [egressCookie]
}
...ests/src/test/groovy/org/openkilda/functionaltests/spec/switches/SwitchValidationSpec.groovy
Outdated
Show resolved
Hide resolved
rtretyak
force-pushed
the
functional/connected_devices_traffgen
branch
2 times, most recently
from
8dc5687
to
df8ff73
Compare
-Also major refactoring of all switch validation tests
niksv
force-pushed
the
functional/connected_devices_traffgen
branch
from
df8ff73
to
96f0b5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.